Closed Bug 737454 Opened 12 years ago Closed 12 years ago

Intermittent test_bug518777.html | Test timed out

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14
Tracking Flags:
Tracking Status
firefox11 --- wontfix
firefox12 --- wontfix
firefox13 --- fixed

People

(Reporter: mbrubeck, Assigned: sgautherie)

References

(
URL
)

Details

(Keywords: intermittent-failure, regression)

Attachments

(2 files)

(Av1) test_bug518777.html: Move code from body to head, Rewrite it a little [Checked in: Comment 10]
3.08 KB, patch
roc
: review+
lsblakk
: approval-mozilla-aurora-
lsblakk
: approval-mozilla-beta-
Details | Diff | Splinter Review
(Bv1-ab) test_bug518777.html: Fix execution order, Rewrite it a little [Checkin: Comment 19]
3.03 KB, patch
Details | Diff | Splinter Review 
The screenshot shows the test harness with "Status: Fail, Passed: 2504, Failed: 1, Todo: 8, currently executing: test_bug569520.html", and "Mozilla Bug 569520" in the test iframe.

https://tbpl.mozilla.org/php/getParsedLog.php?id=10209783&tree=Mozilla-Inbound
Rev3 WINNT 5.1 mozilla-inbound opt test mochitests-4/5 on 2012-03-20 05:01:47 PDT for push 60dd3e5fe989

builder: mozilla-inbound_xp_test-mochitests-4
slave: talos-r3-xp-072
starttime: 1332244907.14
results: warnings (1)
buildid: 20120320034240
builduid: 04f1db1e018742bf9cda6d431bad1fad
revision: 60dd3e5fe989

2766 INFO TEST-START | /tests/layout/base/tests/test_bug514127.html
2767 INFO TEST-PASS | /tests/layout/base/tests/test_bug514127.html | all pixels blue
2768 INFO TEST-END | /tests/layout/base/tests/test_bug514127.html | finished in 51ms
2769 INFO TEST-START | /tests/layout/base/tests/test_bug518777.html
2770 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug518777.html | Test timed out.
args: ['C:\\talos-slave\\test\\build\\bin\\screenshot.exe', 'c:\\docume~1\\cltbld\\locals~1\\temp\\mozilla-test-fail_ny2p16']

2771 INFO TEST-END | /tests/layout/base/tests/test_bug518777.html | finished in 303489ms
(In reply to TinderboxPushlog Robot from comment #4)
> https://tbpl.mozilla.org/php/getParsedLog.php?id=10219851&tree=Firefox

{
2769 INFO TEST-START | /tests/layout/base/tests/test_bug518777.html
2770 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug518777.html | Test timed out.
SCREENSHOT: data:image/png;base64,[ executing test_bug548545.xhtml ]
2771 INFO TEST-END | /tests/layout/base/tests/test_bug518777.html | finished in 302833ms
}

In bug 735805, I fixed (only) the main page going away too soon.
What remains to be fixed would be the iframe executing too soon.
Assignee: nobody → sgautherie.bz
Blocks: 735805
URL: http://mxr.mozilla.org/mozilla-centra...
Status: NEW → ASSIGNED
Keywords: regression
Target Milestone: --- → mozilla14
Comment on attachment 607778 [details] [diff] [review]
(Av1) test_bug518777.html: Move code from body to head, Rewrite it a little
[Checked in: Comment 10]

Review of attachment 607778 [details] [diff] [review]:
-----------------------------------------------------------------

I guess the iframe sometimes finishes loading before the script has been parsed. Good catch!
Attachment #607778 - Flags: review?(roc) → review+
Keywords: checkin-needed
Version: 14 Branch → Trunk
Comment on attachment 607778 [details] [diff] [review]
(Av1) test_bug518777.html: Move code from body to head, Rewrite it a little
[Checked in: Comment 10]

https://hg.mozilla.org/mozilla-central/rev/f374738260ff


[Approval Request Comment]
Regression caused by (bug #): Bug 518777.
User impact if declined: None, but this would help to prevent random-oranges.
Testing completed (on m-c, etc.): This comment.
Risk to taking this patch (and alternatives if risky): None, test-only.
String changes made by this patch: None.
Attachment #607778 - Attachment description: (Av1) test_bug518777.html: Move code from body to head, Rewrite it a little → (Av1) test_bug518777.html: Move code from body to head, Rewrite it a little [Checked in: Comment 10]
Attachment #607778 - Flags: approval-mozilla-beta?
Attachment #607778 - Flags: approval-mozilla-aurora?
Blocks: 518777
No longer blocks: 735805
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
status-firefox12: --- → affected
status-firefox13: --- → affected
Depends on: 735805
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Serge: why did you just cancel a bunch of builds for this push on the mozilla-central tree?
(In reply to Justin Dolske [:Dolske] from comment #11)
> Serge: why did you just cancel a bunch of builds for this push on the
> mozilla-central tree?

These builds are unaffected by this changeset.
That was my first time use of the feature: I got the feeling I wanted then stoppped.
Just FYI, cancelling build jobs can leave the objdir in a bad state and cause later builds to fail.  The cancel button should be used only for test jobs (except on Try, where every build clobbers automatically).

Ideally TBPL should hide the button for build jobs on non-Try trees; I think there's an open bug about that somewhere...
Comment on attachment 607778 [details] [diff] [review]
(Av1) test_bug518777.html: Move code from body to head, Rewrite it a little
[Checked in: Comment 10]

[Triage Comment]
If this isn't going to impact the user I see no reason not to let it ride the trains.
Attachment #607778 - Flags: approval-mozilla-beta?
Attachment #607778 - Flags: approval-mozilla-beta-
Attachment #607778 - Flags: approval-mozilla-aurora?
Attachment #607778 - Flags: approval-mozilla-aurora-
(In reply to TinderboxPushlog Robot from comment #14)
> https://tbpl.mozilla.org/php/getParsedLog.php?id=10236772&tree=Mozilla-
> Inbound
> Rev3 WINNT 5.1 mozilla-inbound opt test mochitests-4/5 on 2012-03-21 03:26:31

Didn't yet have this fix:
https://hg.mozilla.org/integration/mozilla-inbound/rev/537c3637b992
89893:537c3637b992
https://hg.mozilla.org/integration/mozilla-inbound/rev/f374738260ff
89896:f374738260ff


(In reply to TinderboxPushlog Robot from comment #15)
> https://tbpl.mozilla.org/php/getParsedLog.php?id=10251159&tree=Fx-Team
> Rev3 WINNT 5.1 fx-team pgo test mochitests-4/5 on 2012-03-21 13:03:10

Didn't yet have this fix:
https://hg.mozilla.org/integration/fx-team/rev/e4901b5d891a
89738:e4901b5d891a
https://hg.mozilla.org/integration/fx-team/rev/f374738260ff
89824:f374738260ff
status-firefox11: --- → wontfix
status-firefox12: affected → wontfix
status-firefox13: affected → wontfix
Bv1-ab = bug 735805 patch AAv1 + this bug patch Av1,
with
(In reply to Alex Keybl [:akeybl] from bug 735805 comment #77)
> (the above includes blanket approval for the other test fixes for Aurora 13)

NB: Applies cleanly to Beta/12 too.

***

(In reply to Lukas Blakk [:lsblakk] away from bugmail until March 31st from comment #16)
> If this isn't going to impact the user I see no reason not to let it ride
> the trains.

"Overruled", to be able to land bug 735805. Less random oranges helps "developers".
Keywords: checkin-needed
Whiteboard: [orange] → [c-n: Bv1-ab to m-a] [orange]
Comment on attachment 609666 [details] [diff] [review]
(Bv1-ab) test_bug518777.html: Fix execution order, Rewrite it a little [Checkin: Comment 19]

http://hg.mozilla.org/releases/mozilla-aurora/rev/6c2316525c7c
Attachment #609666 - Attachment description: (Bv1-ab) test_bug518777.html: Fix execution order, Rewrite it a little → (Bv1-ab) test_bug518777.html: Fix execution order, Rewrite it a little [Checkin: Comment 19]
Keywords: checkin-needed
Whiteboard: [c-n: Bv1-ab to m-a] [orange] → [orange]
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: