Add frame and iframe globals to the debugger when present in a page

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Firefox 14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Properly debugging a page with frames or iframes requires adding their globals to the debugger instance.
Assignee: nobody → past
Status: NEW → ASSIGNED
Blocks: 676586
Created attachment 608672 [details] [diff] [review]
WIP

Store this for now in case my laptop blows up or something.
Created attachment 609763 [details] [diff] [review]
Working patch

This appears to work well in my testing.
Attachment #608672 - Attachment is obsolete: true
Attachment #609763 - Flags: review?(rcampbell)
Comment on attachment 609763 [details] [diff] [review]
Working patch

only thing I'd advise for your test is if you could wrap the entire thing inside an outer test function, that should prevent gPane and gTab from leaking.
Attachment #609763 - Flags: review?(rcampbell) → review+
(In reply to Rob Campbell [:rc] (:robcee) from comment #3)
> Comment on attachment 609763 [details] [diff] [review]
> Working patch
> 
> only thing I'd advise for your test is if you could wrap the entire thing
> inside an outer test function, that should prevent gPane and gTab from
> leaking.

Good idea, will do.
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/0b6a274e8b5a
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Depends on: 739995
Backed out due to new randomorange:

https://hg.mozilla.org/integration/fx-team/rev/3faec66b9413
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5759f9c0d1eb
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
I had forgotten to note that I relanded this, since it wasn't the one triggering the oranges:

https://hg.mozilla.org/integration/fx-team/rev/5759f9c0d1eb
No longer depends on: 739995
You need to log in before you can comment on or make changes to this bug.