Closed
Bug 737466
Opened 12 years ago
Closed 12 years ago
The Twitter icon should be their bird logo rather than a "t".
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(thunderbird13 fixed)
RESOLVED
FIXED
Thunderbird 14.0
Tracking | Status | |
---|---|---|
thunderbird13 | --- | fixed |
People
(Reporter: florian, Assigned: andreasn)
References
()
Details
Attachments
(2 files, 1 obsolete file)
5.27 KB,
patch
|
bwinton
:
review+
florian
:
review+
bwinton
:
ui-review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
61.75 KB,
image/png
|
Details |
People from twitter requested that we make this change. See for their current logos: https://twitter.com/about/resources/logos
Assignee | ||
Comment 1•12 years ago
|
||
Their logos seems to be very big, while we're actually just need a 16x16 (and resizing don't give a optimal result). Do you have a name of anyone at Twitter I can talk to in order to figure out if we can just use the favicon of twitter.com?
Reporter | ||
Comment 2•12 years ago
|
||
(In reply to Andreas Nilsson (:andreasn) from comment #1) > Their logos seems to be very big, while we're actually just need a 16x16 > (and resizing don't give a optimal result). Do you have a name of anyone at > Twitter I can talk to in order to figure out if we can just use the favicon > of twitter.com? I think Jb can answer that question.
Comment 3•12 years ago
|
||
https://dev.twitter.com/docs/image-resources seems to be the resource you need to refer to. Lmk if you need direct connection.
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Jb Piacentino from comment #3) > https://dev.twitter.com/docs/image-resources seems to be the resource you > need to refer to. > Lmk if you need direct connection. Oh, that looks excellent. Thank you!
Assignee | ||
Comment 5•12 years ago
|
||
This displays the correct twitter icon.
Assignee | ||
Comment 6•12 years ago
|
||
Assignee | ||
Comment 7•12 years ago
|
||
Before and after in all 3 sizes it appears.
Attachment #610150 -
Attachment is obsolete: true
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 610149 [details] [diff] [review] correct twitter icon This is just a image change, so just setting review.
Attachment #610149 -
Flags: review?(bwinton)
Comment 9•12 years ago
|
||
Comment on attachment 610149 [details] [diff] [review] correct twitter icon r=me, and ui-r=me, based mostly off the screenshots! :) Thanks, Blake.
Attachment #610149 -
Flags: ui-review+
Attachment #610149 -
Flags: review?(bwinton)
Attachment #610149 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 10•12 years ago
|
||
Comment on attachment 610149 [details] [diff] [review] correct twitter icon While I see no problem with this patch, I just wanted to add a quick note that the code in the chat/ folder, which is shared between Thunderbird and Instantbird, has a different ownership than the rest of the Thunderbird code (see https://wiki.mozilla.org/Modules/Chat). Ensuring that a peer of the chat module has seen changes before they are checked in would be appreciated. Thanks!
Attachment #610149 -
Flags: review+
Comment 11•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/dcf4e1f6c78d
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Reporter | ||
Comment 12•12 years ago
|
||
Comment on attachment 610149 [details] [diff] [review] correct twitter icon [Approval Request Comment] This trivial appearance change was requested by twitter folks, so I think we should take it on aurora.
Attachment #610149 -
Flags: approval-comm-aurora?
Reporter | ||
Updated•12 years ago
|
Assignee: nobody → nisses.mail
Updated•12 years ago
|
Attachment #610149 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 13•12 years ago
|
||
http://hg.mozilla.org/releases/comm-aurora/rev/34a3c907f9be
status-thunderbird13:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•