The default bug view has changed. See this FAQ.

The Twitter icon should be their bird logo rather than a "t".

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: andreasn)

Tracking

Trunk
Thunderbird 14.0
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
People from twitter requested that we make this change.
See for their current logos: https://twitter.com/about/resources/logos
(Assignee)

Comment 1

5 years ago
Their logos seems to be very big, while we're actually just need a 16x16 (and resizing don't give a optimal result). Do you have a name of anyone at Twitter I can talk to in order to figure out if we can just use the favicon of twitter.com?
(Reporter)

Comment 2

5 years ago
(In reply to Andreas Nilsson (:andreasn) from comment #1)
> Their logos seems to be very big, while we're actually just need a 16x16
> (and resizing don't give a optimal result). Do you have a name of anyone at
> Twitter I can talk to in order to figure out if we can just use the favicon
> of twitter.com?

I think Jb can answer that question.

Comment 3

5 years ago
https://dev.twitter.com/docs/image-resources seems to be the resource you need to refer to.
Lmk if you need direct connection.
(Assignee)

Comment 4

5 years ago
(In reply to Jb Piacentino from comment #3)
> https://dev.twitter.com/docs/image-resources seems to be the resource you
> need to refer to.
> Lmk if you need direct connection.

Oh, that looks excellent. Thank you!
(Assignee)

Comment 5

5 years ago
Created attachment 610149 [details] [diff] [review]
correct twitter icon

This displays the correct twitter icon.
(Assignee)

Comment 6

5 years ago
Created attachment 610150 [details]
screenshot of patch in action
(Assignee)

Comment 7

5 years ago
Created attachment 610242 [details]
before and after screenshot

Before and after in all 3 sizes it appears.
Attachment #610150 - Attachment is obsolete: true
(Assignee)

Comment 8

5 years ago
Comment on attachment 610149 [details] [diff] [review]
correct twitter icon

This is just a image change, so just setting review.
Attachment #610149 - Flags: review?(bwinton)
Comment on attachment 610149 [details] [diff] [review]
correct twitter icon

r=me, and ui-r=me, based mostly off the screenshots!  :)

Thanks,
Blake.
Attachment #610149 - Flags: ui-review+
Attachment #610149 - Flags: review?(bwinton)
Attachment #610149 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Reporter)

Comment 10

5 years ago
Comment on attachment 610149 [details] [diff] [review]
correct twitter icon

While I see no problem with this patch, I just wanted to add a quick note that the code in the chat/ folder, which is shared between Thunderbird and Instantbird, has a different ownership than the rest of the Thunderbird code (see https://wiki.mozilla.org/Modules/Chat). Ensuring that a peer of the chat module has seen changes before they are checked in would be appreciated. Thanks!
Attachment #610149 - Flags: review+
http://hg.mozilla.org/comm-central/rev/dcf4e1f6c78d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
(Reporter)

Comment 12

5 years ago
Comment on attachment 610149 [details] [diff] [review]
correct twitter icon

[Approval Request Comment]
This trivial appearance change was requested by twitter folks, so I think we should take it on aurora.
Attachment #610149 - Flags: approval-comm-aurora?
(Reporter)

Updated

5 years ago
Assignee: nobody → nisses.mail
Attachment #610149 - Flags: approval-comm-aurora? → approval-comm-aurora+
http://hg.mozilla.org/releases/comm-aurora/rev/34a3c907f9be
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.