73748 - Remove nsJSComponentManager.js and nsJSSupportsUtils.js

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Comment 1

[Peter "jag" Annema]

For others interested in this bug:

Basically the changes to be made are:

- nsJSComponentManager.createInstance("contractID", "nsIFoo")
+ Components.classes["contractID"]
+           .createInstance(Components.interfaces.nsIFoo);

and

- nsJSComponentManager.getService("contractID", "nsIFoo")
+ Components.classes["contractID"]
+           .getService(Components.interfaces.nsIFoo);

Comment 2

[Blake Ross]

Mark, do you mind if I take this?  I'm about to whack a bunch of navigator stuff 
as part of the Cool Performance Work.

Comment 3

[Blake Ross]

Taking . . .

Comment 4

[Mark Olson]

At least have the courtesy to cc me blake ;)

Comment 5

[Blake Ross]

Attachment: patch for mail

Comment 6

[Blake Ross]

I've since excised the need for the two files everywhere except 
profileSelection, so next is just to actually remove the references...seth, can 
you r/sr this?

Comment 7

[Blake Ross]

mscott: r/sr, please?

Comment 8

[Blake Ross]

I'm a lazy bastard.  Passing this around for various components to remove this
(starting at view source).  See lxr for who to pass to next.  Unless you want to
patch the few remaining places, doron ;)

Comment 9

[Doron Rosenberg (IBM)]

Attachment: patch for viewsource

patch for viewsource

Comment 10

[Stephen Walker]

doron, can you get this fixed?

Comment 11

[Doron Rosenberg (IBM)]

Sounds simple, 1.4beta for now.

Comment 12

[Doron Rosenberg (IBM)]

Attachment: removes includes of the 2 files

since they are never used, just reference removals.

Comment 13

[timeless]

Comment on attachment 118556 [details] [diff] [review]
removes includes of the 2 files

Index: xpfe/components/prefwindow/resources/content/pref-scripts.xul

don't check that in with this review :)

Comment 14

[rbs]

Comment on attachment 118556 [details] [diff] [review]
removes includes of the 2 files

sr=rbs, modulo what timeless said.
[might be a good time to cvs remove the files themselves if nobody uses them
anymore]

Comment 15

[Doron Rosenberg (IBM)]

er, forgot the cvs removal :)

Timeless, can you check it in?

Comment 16

[jag (Peter Annema)]

Yay!

What's left to be done?

Comment 17

[Doron Rosenberg (IBM)]

Attachment: patch, without parts of another patch :)

Comment 18

[Doron Rosenberg (IBM)]

Comment on attachment 121201 [details] [diff] [review]
patch, without parts of another patch :)

carrying the r/sr over.

jag - needs to be checked in, that's all :)

Comment 19

[jag (Peter Annema)]

timeless checked that in yesterday.

Comment 20

[Doron Rosenberg (IBM)]

timeless, thanks for stating so in the bug :)

looks like 2 new references cropped up, lemme post a new patch.

Comment 21

[Doron Rosenberg (IBM)]

Attachment: removes 2 more references - the last

removes the last 2 references to the file

Comment 22

[jag (Peter Annema)]

Comment on attachment 121234 [details] [diff] [review]
removes 2 more references - the last

sr=jag

You'll need someone to cover the Netscape tree for you before you cvs remove
these two js files.

Comment 23

[jag (Peter Annema)]

I just checked (well, Joe Hewitt did, thanks!) and no references to these files
in the NS tree. Go ahead and kill them!

Comment 24

[Doron Rosenberg (IBM)]

yeah, i checked commercial too, forget to state so.

Comment 25

[timeless]

i removed the files, doron: that's all, right?

Comment 26

[Doron Rosenberg (IBM)]

yup