Closed Bug 737553 Opened 8 years ago Closed 8 years ago

During scroll we paint a lot outside of the visible area.

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
firefox14 --- fixed

People

(Reporter: jrmuizel, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [viewport])

Attachments

(2 files)

On a nexus S we have a display port of +600 pixels and a screen size of 480pixels. This means that during scrolling we're painting more that's not visible than is visible. We should avoid doing this.
Blocks: 729391
I implemented this as one of the strategies in bug 729528. Once I have checkerboarding test data from different devices I should know how much this helps.
Assignee: nobody → bugmail.mozilla
Depends on: 729528
OS: Linux → Android
Hardware: x86_64 → ARM
Whiteboard: [viewport]
The change comment describes the actual changes (other than refactoring) that were made. The diff is probably very hard to read, so I put a copy of DisplayPortCalculator with the patch applied at http://people.mozilla.org/~kgupta/tmp/DisplayPortCalculator.java - it is probably just easier to read through this file and check that it makes sense.
Attachment #610644 - Flags: review?(chrislord.net)
Comment on attachment 610643 [details] [diff] [review]
(1/2) Fix up null object handling

Review of attachment 610643 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r+.

::: mobile/android/base/GeckoAppShell.java
@@ +1765,5 @@
>              if (response != null)
>                  return response;
>  
>          } catch (Exception e) {
> +            Log.i(LOGTAG, "handleGeckoMessage throws " + e, e);

Perhaps along with this change, this should be Log.e? This is definitely an error, not just information.
Attachment #610643 - Flags: review?(chrislord.net) → review+
Comment on attachment 610644 [details] [diff] [review]
(2/2) Refactor and tune strategies

Review of attachment 610644 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! r+
Attachment #610644 - Flags: review?(chrislord.net) → review+
Blocks: 733041
You need to log in before you can comment on or make changes to this bug.