737556 - extra email notification sent for fennec "all signed builds available"

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P3)

Description

[Chris AtLee [:catlee]]

For Firefox 12.0b1 we got an email extra notification once signing was done. The subject was also incorrect:
"[release] Fennec 11.0b5 build1: All signed builds now available"

Comment 1

[Chris AtLee [:catlee]]

according to the email headers, the extra notification was sent from dev-master01, so I'm guessing somebody's staging instance is at fault here.

Comment 2

[Rail Aliiev [:rail]]

We should set the following staging variables to [e-mail] or just [].

releaseConfig['AllRecipients']       = ['[e-mail]',]
releaseConfig['ImportantRecipients'] = ['[e-mail]',]
releaseConfig['AVVendorsRecipients'] = ['[e-mail]',]

Comment 3

[[e-mail] (:bhearsum)]

Bulk move of bugs to Release Automation component.

Comment 4

[[e-mail] (:bhearsum)]

Mass move of bugs to Release Automation component.

Comment 5

[[e-mail] (:bhearsum)]

This sounds like the result of someone's staging master being set-up incorrectly...

Comment 6

[[e-mail] (:bhearsum)]

(In reply to Rail Aliiev [:rail] from comment #2)
> We should set the following staging variables to [e-mail] or just
> [].
> 
> releaseConfig['AllRecipients']       = ['[e-mail]',]
> releaseConfig['ImportantRecipients'] = ['[e-mail]',]
> releaseConfig['AVVendorsRecipients'] = ['[e-mail]',]

This is easy, let's do this.

Comment 7

[Rail Aliiev [:rail]]

Attachment: nobody

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 668994 [details] [diff] [review]
nobody

wouldn't this give us twistd errors because of returned mail? if I am right can we have a [e-mail] that auto-deletes or something [like [e-mail]] instead?

Comment 9

[[e-mail] (:bhearsum)]

(In reply to Justin Wood (:Callek) from comment #8)
> Comment on attachment 668994 [details] [diff] [review]
> nobody
> 
> wouldn't this give us twistd errors because of returned mail? if I am right
> can we have a [e-mail] that auto-deletes or something [like
> [e-mail]] instead?

If you're running your own staging release you should update these to point at only yourself. Preproduction automatically overrides in: https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/preproduction_release_overrides.py

The point here is to prevent accidentally spamming the entire group with your staging release results.

Comment 10

[Rail Aliiev [:rail]]

(In reply to Ben Hearsum [:bhearsum] from comment #9)
> If you're running your own staging release you should update these to point
> at only yourself.

Yeah. I didn't want to set it to None to even block staging reconfig without local modifications. :)

Comment 11

[Rail Aliiev [:rail]]

Comment on attachment 668994 [details] [diff] [review]
nobody

http://hg.mozilla.org/build/buildbot-configs/rev/dbc3cf1daa48

Comment 12

[Aki Sasaki (not active)]

(In reply to Ben Hearsum [:bhearsum] from comment #9)
> The point here is to prevent accidentally spamming the entire group with
> your staging release results.

I think this patch failed in that regard.

Comment 13

[Rail Aliiev [:rail]]

(In reply to Aki Sasaki [:aki] from comment #12)
> (In reply to Ben Hearsum [:bhearsum] from comment #9)
> > The point here is to prevent accidentally spamming the entire group with
> > your staging release results.
> 
> I think this patch failed in that regard.

I 100% agree.

Comment 14

[[e-mail] (:bhearsum)]

Simple fix would be to change the "sender" on the mailnotifiers. Can't do that easily just for staging, not sure if we'd want to do it for production.

Comment 15

[Aki Sasaki (not active)]

Attachment: stop spamming

Comment 16

[Aki Sasaki (not active)]

Comment on attachment 671519 [details] [diff] [review]
stop spamming

http://hg.mozilla.org/build/buildbot-configs/rev/eb5bf5bad2ed