737651 - Remove some unused Android IME events (from Native Fennec after XUL Fennec is EOL'd)

Status: RESOLVED DUPLICATE of bug 807124

(Firefox for Android Graveyard :: Keyboards and IME, defect, P4)

Description

[Chris Peterson [:cpeterson]]

The following Android IME events and flags are no longer generated by our code, so we can remove code that checks for them:

IME_GET_SELECTION
IME_GET_TEXT
IME_RANGE_SELECTEDCONVERTEDTEXT
IME_RANGE_SELECTEDRAWTEXT

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: bug-737651-remove-unused-ime-events.patch

Remove unused Android IME events: IME_GET_SELECTION, IME_GET_TEXT, IME_RANGE_SELECTEDCONVERTEDTEXT, IME_RANGE_SELECTEDRAWTEXT.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 607730 [details] [diff] [review]
bug-737651-remove-unused-ime-events.patch

Review of attachment 607730 [details] [diff] [review]:
-----------------------------------------------------------------

Are these unused in embedding/android as well?

Comment 3

[Chris Peterson [:cpeterson]]

oops, these events are used in embedding/android. I will sit on this bug until XUL Fennec is EOL'd.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

This is going to be part of Bug 807124.

Comment 5

[Chris Peterson [:cpeterson]]

jchen, did you intend to say that this bug will be fixed in bug 807124, even though you marked that bug as WONTFIX? This bug is about removing from mobile/android/ and widget/android/ that is no longer needed.

Comment 6

[Chris Peterson [:cpeterson]]

Did you mean to say this bug would be fixed by bug 847823?

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Chris Peterson (:cpeterson) from comment #5)
> jchen, did you intend to say that this bug will be fixed in bug 807124, even
> though you marked that bug as WONTFIX? This bug is about removing from
> mobile/android/ and widget/android/ that is no longer needed.

Hm I don't know what I intended :)  I think I was thinking about the bug that removes embedding/android, and thought that bug encompassed this bug. Feel free to reopen if needed.

(In reply to Chris Peterson (:cpeterson) from comment #6)
> Did you mean to say this bug would be fixed by bug 847823?

That bug will remove the fullscreen argument from notifyIMEEnabled, but otherwise it's mostly name changes.