Update clang to r152341 on Mac/Linux slaves

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: decoder, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
There is a bug in ASan (included in Clang/LLVM/Compiler-rt) that breaks the whole symbolizing of traces emitted by ASan. Basically you cannot get any symbols from the traces outputted for Firefox. This bug was fixed in r152341. I think it would be sufficient to upgrade compiler-rt only but I suggested we upgrade everything because I previously experienced problems when updating only one of the three revs. Revs above the mentioned should be ok.
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Created attachment 607796 [details] [diff] [review]
update clang to 152341 on linux
Attachment #607796 - Flags: review?
Attachment #607796 - Flags: review? → review?(rail)
Created attachment 607797 [details] [diff] [review]
update clang to 152341 on os x
Attachment #607797 - Flags: review?(rail)
(Assignee)

Updated

6 years ago
Attachment #607796 - Flags: review?(rail) → review+
(Assignee)

Updated

6 years ago
Attachment #607797 - Flags: review?(rail) → review+
(Assignee)

Comment 3

6 years ago
Rafael, please assign the bug to me when you're done with testing.
Comment on attachment 607796 [details] [diff] [review]
update clang to 152341 on linux

https://hg.mozilla.org/build/rpm-sources/rev/22a4ebf2a555
Attachment #607796 - Flags: checked-in+
Comment on attachment 607797 [details] [diff] [review]
update clang to 152341 on os x

https://hg.mozilla.org/build/braindump/rev/ba39ac1ed906
Attachment #607797 - Flags: checked-in+
Created attachment 608040 [details] [diff] [review]
puppet manifest for r152341

This update still removes the old version. I will try to change it to keep both next time we have to update.
Attachment #608040 - Flags: review?(rail)
Assignee: respindola → rail
(Assignee)

Comment 7

6 years ago
Comment on attachment 608040 [details] [diff] [review]
puppet manifest for r152341

lgtm, I'll land it soon.
Attachment #608040 - Flags: review?(rail) → review+
(Assignee)

Comment 8

6 years ago
Comment on attachment 608040 [details] [diff] [review]
puppet manifest for r152341

http://hg.mozilla.org/build/puppet-manifests/rev/f682738a00b3
Attachment #608040 - Flags: checked-in+
(Assignee)

Comment 9

6 years ago
Deployment started. The package should be available on the builders by tomorrow.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

6 years ago
The packages themselves are at http://people.mozilla.org/~raliiev/clang/
Looks like it is working
https://tbpl.mozilla.org/?tree=Try&rev=1d7631bc887f
(Assignee)

Comment 12

6 years ago
\o/
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.