Closed Bug 737677 Opened 12 years ago Closed 12 years ago

Fix sub-optimal handling of -Wno-extended-offsetof for older versions of clang

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: n.nethercote, Unassigned)

References

Details

Attachments

(1 file)

patch
2.68 KB, patch
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #711895 +++

Bug 711895's changes relating to -Wno-extended-offsetof are sub-optimal -- they don't break the build, but an unsupported option is passed to clang (and clang ignores it).

See bug 711895 comment 49 and 711895 comment 51 for details and a suggested fix.
Attached patch patch — — Splinter Review 
This patch is from Irving Reid.

I found the docs for GCC 3.0.4 and -Werror was supported then, so I think we're safe to use it without any kind of check!
Attachment #607835 - Flags: review?(ted.mielczarek)
Bug 711895 was backed out due to i10n bustage.  I'll fix this problem there when I reland.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #607835 - Flags: review?(ted.mielczarek)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: