Fix sub-optimal handling of -Wno-extended-offsetof for older versions of clang

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: njn, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #711895 +++

Bug 711895's changes relating to -Wno-extended-offsetof are sub-optimal -- they don't break the build, but an unsupported option is passed to clang (and clang ignores it).

See bug 711895 comment 49 and 711895 comment 51 for details and a suggested fix.
(Reporter)

Comment 1

5 years ago
Created attachment 607835 [details] [diff] [review]
patch

This patch is from Irving Reid.

I found the docs for GCC 3.0.4 and -Werror was supported then, so I think we're safe to use it without any kind of check!
Attachment #607835 - Flags: review?(ted.mielczarek)
Blocks: 734080
(Reporter)

Comment 2

5 years ago
Bug 711895 was backed out due to i10n bustage.  I'll fix this problem there when I reland.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment #607835 - Flags: review?(ted.mielczarek)
You need to log in before you can comment on or make changes to this bug.