Last Comment Bug 737677 - Fix sub-optimal handling of -Wno-extended-offsetof for older versions of clang
: Fix sub-optimal handling of -Wno-extended-offsetof for older versions of clang
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on: 711895
Blocks: 734080
  Show dependency treegraph
Reported: 2012-03-20 15:55 PDT by Nicholas Nethercote [:njn]
Modified: 2012-03-23 09:05 PDT (History)
15 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (2.68 KB, patch)
2012-03-20 19:21 PDT, Nicholas Nethercote [:njn]
no flags Details | Diff | Splinter Review

Description User image Nicholas Nethercote [:njn] 2012-03-20 15:55:41 PDT
+++ This bug was initially created as a clone of Bug #711895 +++

Bug 711895's changes relating to -Wno-extended-offsetof are sub-optimal -- they don't break the build, but an unsupported option is passed to clang (and clang ignores it).

See bug 711895 comment 49 and 711895 comment 51 for details and a suggested fix.
Comment 1 User image Nicholas Nethercote [:njn] 2012-03-20 19:21:40 PDT
Created attachment 607835 [details] [diff] [review]

This patch is from Irving Reid.

I found the docs for GCC 3.0.4 and -Werror was supported then, so I think we're safe to use it without any kind of check!
Comment 2 User image Nicholas Nethercote [:njn] 2012-03-21 22:19:47 PDT
Bug 711895 was backed out due to i10n bustage.  I'll fix this problem there when I reland.

Note You need to log in before you can comment on or make changes to this bug.