737748 - Add a preference for controlling automatic screen orientation

Status: RESOLVED INVALID

(Firefox OS Graveyard :: General, defect)

Description

[Cervantes Yu [:cyu] [:cervantes]]

We need to add a preference (default disabled) for automatic screen rotation.

Comment 1

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Add a preference for controlling automatic screen orientation

Rebase from https://github.com/cgjones/mozilla-central/commit/56e48a434ac30ca6fc9d645e5423f2510f81273d

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 607892 [details] [diff] [review]
Add a preference for controlling automatic screen orientation

If the pref is false, we shouldn't try to create the sensor observer at all.  In this patch, we still turn on the sensor HW when the pref is off.

Comment 3

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Add a preference for controlling automatic screen orientation (v2)

Change to v1: don't init HW if preference value is false

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 608306 [details] [diff] [review]
Add a preference for controlling automatic screen orientation (v2)

Sorry for the review latency.

Comment 5

[Andrew Overholt [:overholt]]

Does this patch still apply?  Can we get it into the tree?

I'm setting blocking-basecamp- but that doesn't mean it wouldn't be appreciated :)

Comment 6

[Cervantes Yu [:cyu] [:cervantes]]

Hi Andrew,

This patch doesn't apply now and is no longer necessary. Please close this bug. Thanks :).

Comment 7

[Andrew Overholt [:overholt]]

Thanks, Cervantes.