Add a preference for controlling automatic screen orientation

RESOLVED INVALID

Status

RESOLVED INVALID
7 years ago
7 years ago

People

(Reporter: cyu, Assigned: cyu)

Tracking

unspecified
All
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-basecamp:-)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We need to add a preference (default disabled) for automatic screen rotation.
(Assignee)

Comment 1

7 years ago
Created attachment 607892 [details] [diff] [review]
Add a preference for controlling automatic screen orientation

Rebase from https://github.com/cgjones/mozilla-central/commit/56e48a434ac30ca6fc9d645e5423f2510f81273d
Attachment #607892 - Flags: review?(jones.chris.g)
Comment on attachment 607892 [details] [diff] [review]
Add a preference for controlling automatic screen orientation

If the pref is false, we shouldn't try to create the sensor observer at all.  In this patch, we still turn on the sensor HW when the pref is off.
Attachment #607892 - Flags: review?(jones.chris.g)
(Assignee)

Comment 3

7 years ago
Created attachment 608306 [details] [diff] [review]
Add a preference for controlling automatic screen orientation (v2)

Change to v1: don't init HW if preference value is false
Attachment #607892 - Attachment is obsolete: true
Attachment #608306 - Flags: review?(jones.chris.g)
Comment on attachment 608306 [details] [diff] [review]
Add a preference for controlling automatic screen orientation (v2)

Sorry for the review latency.
Attachment #608306 - Flags: review?(jones.chris.g) → review+
Does this patch still apply?  Can we get it into the tree?

I'm setting blocking-basecamp- but that doesn't mean it wouldn't be appreciated :)
blocking-basecamp: --- → -
(Assignee)

Comment 6

7 years ago
Hi Andrew,

This patch doesn't apply now and is no longer necessary. Please close this bug. Thanks :).
Thanks, Cervantes.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.