737751 - crash in nsMsgComposeAndSend::ProcessMultipartRelated

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Wayne Mery (:wsmwk)]

This bug was filed from the Socorro interface and is 
report bp-19fec5ed-5218-4eee-8947-560ce2120316 .
============================================================= 

#10 crash for v11.
no crashes prior to version 11. So assuming regression

0xul.dllnsMsgComposeAndSend::ProcessMultipartRelated mailnews/compose/src/nsMsgSend.cpp:1929 1xul.dllnsMsgComposeAndSend::HackAttachments mailnews/compose/src/nsMsgSend.cpp:2531 2xul.dllnsMsgComposeAndSend::Init mailnews/compose/src/nsMsgSend.cpp:3394 3xul.dllnsMsgComposeAndSend::CreateAndSendMessage mailnews/compose/src/nsMsgSend.cpp:4243 4xul.dllnsMsgCompose::_SendMsg mailnews/compose/src/nsMsgCompose.cpp:1076 5xul.dllnsMsgCompose::SendMsg mailnews/compose/src/nsMsgCompose.cpp:1270 6xul.dllNS_InvokeByIndex_P xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102 7xul.dllXPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:2216 8xul.dllXPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1562 9mozjs.dlljs::InvokeKernel js/src/jsinterp.cpp:625

Comment 1

[Makoto Kato [:m_kato]]

attachment.m_url seems to be null...

Comment 2

[David :Bienvenu]

The most recent change in that area (making send scriptable) only changed the name of the member variable. I suspect this is similar to bug 714825. I'll see if I can find a fix for TB 12.

Comment 3

[David :Bienvenu]

Figuring out hwo to reproduce this would be very helpful. I can certainly add null checks, but I don't know where else we'd crash.

Comment 4

[David :Bienvenu]

Attachment: null check fix

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 611952 [details] [diff] [review]
null check fix

[Triage Comment]

Comment 6

[David :Bienvenu]

http://hg.mozilla.org/comm-central/rev/e4d995aecc04 fixed on trunk.

Comment 7

[David :Bienvenu]

marking fixed, though we don't know if a downstream crash will appear. We'll have to keep our eyes open for that.

Comment 8

[Mark Banner (:standard8)]

Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/93adc53b2fa2
http://hg.mozilla.org/releases/comm-beta/rev/c09e188e7fe1