Last Comment Bug 737751 - crash in nsMsgComposeAndSend::ProcessMultipartRelated
: crash in nsMsgComposeAndSend::ProcessMultipartRelated
: crash, regression
Product: MailNews Core
Classification: Components
Component: Composition (show other bugs)
: Trunk
: x86 All
-- critical (vote)
: Thunderbird 14.0
Assigned To: David :Bienvenu
Depends on:
  Show dependency treegraph
Reported: 2012-03-20 21:39 PDT by Wayne Mery (:wsmwk, NI for questions)
Modified: 2012-04-03 14:23 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

null check fix (829 bytes, patch)
2012-04-03 13:25 PDT, David :Bienvenu
standard8: review+
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description User image Wayne Mery (:wsmwk, NI for questions) 2012-03-20 21:39:02 PDT
This bug was filed from the Socorro interface and is 
report bp-19fec5ed-5218-4eee-8947-560ce2120316 .

#10 crash for v11.
no crashes prior to version 11. So assuming regression

0xul.dllnsMsgComposeAndSend::ProcessMultipartRelated mailnews/compose/src/nsMsgSend.cpp:1929 1xul.dllnsMsgComposeAndSend::HackAttachments mailnews/compose/src/nsMsgSend.cpp:2531 2xul.dllnsMsgComposeAndSend::Init mailnews/compose/src/nsMsgSend.cpp:3394 3xul.dllnsMsgComposeAndSend::CreateAndSendMessage mailnews/compose/src/nsMsgSend.cpp:4243 4xul.dllnsMsgCompose::_SendMsg mailnews/compose/src/nsMsgCompose.cpp:1076 5xul.dllnsMsgCompose::SendMsg mailnews/compose/src/nsMsgCompose.cpp:1270 6xul.dllNS_InvokeByIndex_P xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102 7xul.dllXPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:2216 8xul.dllXPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1562 9mozjs.dlljs::InvokeKernel js/src/jsinterp.cpp:625
Comment 1 User image Makoto Kato [:m_kato] 2012-03-21 05:32:14 PDT
attachment.m_url seems to be null...
Comment 2 User image David :Bienvenu 2012-03-21 07:10:31 PDT
The most recent change in that area (making send scriptable) only changed the name of the member variable. I suspect this is similar to bug 714825. I'll see if I can find a fix for TB 12.
Comment 3 User image David :Bienvenu 2012-03-21 13:07:55 PDT
Figuring out hwo to reproduce this would be very helpful. I can certainly add null checks, but I don't know where else we'd crash.
Comment 4 User image David :Bienvenu 2012-04-03 13:25:35 PDT
Created attachment 611952 [details] [diff] [review]
null check fix
Comment 5 User image Mark Banner (:standard8) 2012-04-03 13:26:51 PDT
Comment on attachment 611952 [details] [diff] [review]
null check fix

[Triage Comment]
Comment 6 User image David :Bienvenu 2012-04-03 13:29:36 PDT fixed on trunk.
Comment 7 User image David :Bienvenu 2012-04-03 13:35:59 PDT
marking fixed, though we don't know if a downstream crash will appear. We'll have to keep our eyes open for that.

Note You need to log in before you can comment on or make changes to this bug.