Closed Bug 737774 Opened 12 years ago Closed 8 years ago

HTML5 Video controls no longer fade out when mouse leaves video or when mouse is left still on top of video

Categories

(Toolkit :: Video/Audio Controls, defect)

13 Branch
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jaws, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

The patch for bug 729111 set this.clickToPlay.hidden to false even after the clickToPlay button had been dismissed, causing the controls to no longer fade out.

Charles, would you like to take a stab at fixing this?
I will have a look at it in a couple days.
Steps to reproduce:
1. Visit a page with an HTML5 video. (eg. http://www.mozilla.org/en-US/firefox/video/)
2. Click the center play button.
3. Move the mouse cursor outside of the video area.
4. Move the mouse cursor back into the video area -- center play button reappears but does not fade out again.
Hello Jared, could you please review the additional changes? (assuming the 'steps to reproduce' above are correct)
Attachment #608226 - Flags: review?(jwein)
Comment on attachment 608226 [details] [diff] [review]
Bug-737774: Patch-1

Review of attachment 608226 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/widgets/videocontrols.xml
@@ +1264,5 @@
>                      if ((this._overlayPlayButtonHeight + this._controlBarHeight) > videoHeight ||
>                          this._overlayPlayButtonWidth > videoWidth)
>                          this.clickToPlay.hidden = true;
> +                    else if (this.clickToPlay.hidden &&
> +                             this.video.paused)

We only want the large play button to show if the video hasn't been played. We'll probably have to add a property to |this| that keeps track of if the play event has been fired, and only show unhide the clickToPlay button if the property is false.

This would all be easier if https://bugzilla.mozilla.org/show_bug.cgi?id=462959 gets fixed. If your up to it, it looks like there is a finished patch in that bug that just needs the test fixed (and the patch rebased) before it can be relanded.
Attachment #608226 - Flags: review?(jwein) → feedback+
This works for me on Windows 10 Nightly 2016-05-04. It must have been fixed by another bug in the meantime.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: