737775 - Prevent firing 500 on attachment name validation

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P4)

Description

[Piotr Zalewa [:zalun]]

Traceback:

Traceback (most recent call last):

[...]

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/jetpack/views.py", line 770, in rename_attachment
    attachment = revision.update(attachment)

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/jetpack/models.py", line 902, in update
    return change.increment(self)

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/jetpack/models.py", line 2321, in increment
    self.save()

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/base/models.py", line 16, in save
    self.full_clean()

  File "/data/www/builder.addons.mozilla.org/flightdeck/vendor/lib/python/django/db/models/base.py", line 828, in full_clean
    raise ValidationError(errors)

ValidationError: {'ext': [u'Ensure this value has at most 10 characters (it has 16).']}

Comment 1

[Piotr Zalewa [:zalun]]

I think raising 403 will do the job.
There is a need to search for other raise ValidationError thought.

Comment 2

[Piotr Zalewa [:zalun]]

r? https://github.com/mozilla/FlightDeck/pull/157

I've added transaction.on_success to the view, but this is still creating a new revision. Check is needed if that is still the case on test server.