Closed Bug 737863 Opened 8 years ago Closed 8 years ago

nsBaseHashtable::SizeOfExcludingThis should be declared const

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(1 file)

Lack of 'const' here interferes with const-ifying a bunch of the functions being added in bug 688125.
Attachment #607948 - Flags: review?(n.nethercote)
Comment on attachment 607948 [details] [diff] [review]
patch, add const to the declaration

Thanks!
Attachment #607948 - Flags: review?(n.nethercote) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbd51616925a
Assignee: nobody → jfkthame
Target Milestone: --- → mozilla14
One of the patches in this push caused winxp debug mochitests to perma-hang in test_memoryReporters.xul. Backed the entire push out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0dfb71a2df9
Re-landed, as I don't think this can be the culprit:
https://hg.mozilla.org/integration/mozilla-inbound/rev/405657ee89b0
https://hg.mozilla.org/mozilla-central/rev/405657ee89b0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.