nsBaseHashtable::SizeOfExcludingThis should be declared const

RESOLVED FIXED in mozilla14

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Lack of 'const' here interferes with const-ifying a bunch of the functions being added in bug 688125.
(Assignee)

Comment 1

6 years ago
Created attachment 607948 [details] [diff] [review]
patch, add const to the declaration
Attachment #607948 - Flags: review?(n.nethercote)
Comment on attachment 607948 [details] [diff] [review]
patch, add const to the declaration

Thanks!
Attachment #607948 - Flags: review?(n.nethercote) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbd51616925a
Assignee: nobody → jfkthame
Target Milestone: --- → mozilla14
One of the patches in this push caused winxp debug mochitests to perma-hang in test_memoryReporters.xul. Backed the entire push out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0dfb71a2df9
(Assignee)

Comment 5

6 years ago
Re-landed, as I don't think this can be the culprit:
https://hg.mozilla.org/integration/mozilla-inbound/rev/405657ee89b0

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/405657ee89b0
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.