Last Comment Bug 737863 - nsBaseHashtable::SizeOfExcludingThis should be declared const
: nsBaseHashtable::SizeOfExcludingThis should be declared const
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Jonathan Kew (:jfkthame)
:
Mentors:
Depends on:
Blocks: 688125
  Show dependency treegraph
 
Reported: 2012-03-21 07:42 PDT by Jonathan Kew (:jfkthame)
Modified: 2012-03-24 13:42 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch, add const to the declaration (1.09 KB, patch)
2012-03-21 07:43 PDT, Jonathan Kew (:jfkthame)
n.nethercote: review+
Details | Diff | Review

Description Jonathan Kew (:jfkthame) 2012-03-21 07:42:26 PDT
Lack of 'const' here interferes with const-ifying a bunch of the functions being added in bug 688125.
Comment 1 Jonathan Kew (:jfkthame) 2012-03-21 07:43:02 PDT
Created attachment 607948 [details] [diff] [review]
patch, add const to the declaration
Comment 2 Nicholas Nethercote [:njn] (on vacation until July 11) 2012-03-21 17:09:23 PDT
Comment on attachment 607948 [details] [diff] [review]
patch, add const to the declaration

Thanks!
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-03-23 14:06:50 PDT
One of the patches in this push caused winxp debug mochitests to perma-hang in test_memoryReporters.xul. Backed the entire push out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0dfb71a2df9
Comment 5 Jonathan Kew (:jfkthame) 2012-03-23 15:16:45 PDT
Re-landed, as I don't think this can be the culprit:
https://hg.mozilla.org/integration/mozilla-inbound/rev/405657ee89b0
Comment 6 Ed Morley [:emorley] 2012-03-24 13:42:28 PDT
https://hg.mozilla.org/mozilla-central/rev/405657ee89b0

Note You need to log in before you can comment on or make changes to this bug.