737892 - Additional cleanup of Thunderbird Test Pilot

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[:Irving Reid (No longer working on Firefox)]

+++ This bug was initially created as a clone of Bug #731532 +++

Cleaned up all other warnings in Test Pilot (except one issue, where the "debug.html" page fails when it opens in a tab at TB startup time because the web tab onLoad() is called before Test Pilot is initialized).

As part of this, a touch-up to errUtils.js to make it less likely to throw exceptions when printing events.

Comment 1

[:Irving Reid (No longer working on Firefox)]

Attachment: Resolve more Test Pilot errors/warnings under Thunderbird

Added mail-toolbar to Thunderbird's hiddenwindow.xul so the Test Pilot initializes correctly (and displays menu items correctly) even when all windows are closed on Mac - the "no-windows-open" toolbar includes Tools/Test Pilot as it should.

Cleaned up a couple of other nits, renamed a "window" parameter in several places so it wouldn't be confused for the JS window global, etc.

Comment 3

[:Irving Reid (No longer working on Firefox)]

Attachment: Resolve more Test Pilot errors/warnings under Thunderbird, updated

Slight mid-air collision with bug 739228, updated my patch.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/50dfe05b31d6

Comment 5

[Philip Chee]

Are you going to upstream your fixes?

Comment 6

[Mark Banner (:standard8)]

(In reply to Philip Chee from comment #5)
> Are you going to upstream your fixes?

At the moment, the three codebases (FF/Mobile/TB) are diverged, and I believe the core guys are working on re-unifying those. I'm filing bugs on the changes we're making so that they know to pick them up. If folks want to pick those up, that's fine, but we haven't got the time at the moment to do the necessary back-port testing on Firefox and Mobile to ensure the patches haven't broken anything there.

Comment 7

[:Irving Reid (No longer working on Firefox)]

(In reply to Philip Chee from comment #5)
> Are you going to upstream your fixes?

I've been using using Bug 736984 to track Thunderbird changes that may need to be back ported.

Comment 8

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

To clarify.  We have an official 1.2.1 in AMO that reflects what the "firefox" build should look like.  We are going to roll in tbird changes (from this patch and others) in the next week or two, then hopefully the codebases will be unified :)  standard8, let's talk details about what fits best into your flow soon!  (offline, not in this bug!)