737930 - Switch marionette enabling from build flag to config variable

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Instead of using build flags, we can switch to configure variables, and set them in confvars.sh. We'll need to turn it on by default for the B2G confvars.sh file (m-c/b2g/confvars.sh), but we don't need it for any other build right now.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Once it lands, we'll need to get rid of the '--enable-marionette' option in /b2g/config/mozconfigs/

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: Remove the flag handler, add confvars.sh line for b2g

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Tested this on b2g and on m-c (where you have to add the variable to browser/confvars.sh), and both work well.

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 609771 [details] [diff] [review]
Remove the flag handler, add confvars.sh line for b2g

Looks good.  We'll have to remove --enable-marionette from https://github.com/andreasgal/B2G/blob/master/config/gecko-prof-gonk at the same time this gets checked in, in order to avoid breaking the build.  I can do that when I land this patch.

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

Awesome, thanks! Also, it won't break the build; unused build flags are just ignored.

Comment 6

[Jonathan Griffin (:jgriffin)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3c6e6afdfd4a

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3c6e6afdfd4a