Created attachment 608025 [details] Filelink interpreted as attachment STR - Create a Filelink - Send - Locate it in the Sent folder - It's presented as if it contained a regular attachment (21 byte long). Expected behaviour: - Do not mark it as containing an attachment.
they do have an attachment, the html part that describes the file link.
Ok, fair enough. But the attachment is not interpreted as an html part, but rather as the original file type. In the attached screenshot for example, it looks like a jpg file, of 21 bytes size, and TB tries to render it... and fails. That does not seem right, does it ?
Isn't it just that it renders the html part, but the remote image isn't allowed to be shown?
(In reply to Magnus Melin from comment #3) > Isn't it just that it renders the html part, but the remote image isn't > allowed to be shown? we can't render the remote image - we just have a link to a web page which has a download link somewhere on it...
If I had to guess, it's trying to render the html part as a jpg.
things are all still a bit of blur after the exciting big files landing. My intent was that the attachments have text/html content-type, but it looks like they have the attachment type of the actual attachment. They've also got Content-Disposition: attachment; filename="713645.txt". I think if I took out the filename part on save/send, then we wouldn't show the attachment in the attachment area, and I need to fix the content type as well. And then I have to make sure that loading a draft msg with a big file attachment gets the filename from the X-Mozilla-Cloud-Part header...
Created attachment 610801 [details] [diff] [review] proposed fix this makes the cloud part be text/html, and puts in a link, and removes the filename so we won't display it as an attachment in the UI.
Comment on attachment 610801 [details] [diff] [review] proposed fix Review of attachment 610801 [details] [diff] [review]: ----------------------------------------------------------------- This makes sense to me. Good stuff!
Comment on attachment 610801 [details] [diff] [review] proposed fix [Approval Request Comment] User impact if declined: cloud file attachments show up as real attachments in attachment pane.
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/99876e31f37e
5 years ago
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/477abb7f3627
5 years ago