Closed
Bug 737941
Opened 13 years ago
Closed 13 years ago
Sent emails containing a Filelink appear as containing a (fake) attachment
Categories
(Thunderbird :: Message Reader UI, defect)
Tracking
(thunderbird13 fixed)
RESOLVED
FIXED
Thunderbird 14.0
Tracking | Status | |
---|---|---|
thunderbird13 | --- | fixed |
People
(Reporter: jb, Assigned: Bienvenu)
References
Details
Attachments
(2 files)
73.81 KB,
image/png
|
Details | |
2.69 KB,
patch
|
mconley
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
STR
- Create a Filelink
- Send
- Locate it in the Sent folder
- It's presented as if it contained a regular attachment (21 byte long).
Expected behaviour:
- Do not mark it as containing an attachment.
Reporter | ||
Updated•13 years ago
|
Hardware: x86_64 → All
Assignee | ||
Comment 1•13 years ago
|
||
they do have an attachment, the html part that describes the file link.
Reporter | ||
Comment 2•13 years ago
|
||
Ok, fair enough.
But the attachment is not interpreted as an html part, but rather as the original file type. In the attached screenshot for example, it looks like a jpg file, of 21 bytes size, and TB tries to render it... and fails. That does not seem right, does it ?
Comment 3•13 years ago
|
||
Isn't it just that it renders the html part, but the remote image isn't allowed to be shown?
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Magnus Melin from comment #3)
> Isn't it just that it renders the html part, but the remote image isn't
> allowed to be shown?
we can't render the remote image - we just have a link to a web page which has a download link somewhere on it...
Comment 5•13 years ago
|
||
If I had to guess, it's trying to render the html part as a jpg.
Assignee | ||
Comment 6•13 years ago
|
||
things are all still a bit of blur after the exciting big files landing. My intent was that the attachments have text/html content-type, but it looks like they have the attachment type of the actual attachment. They've also got Content-Disposition: attachment;
filename="713645.txt". I think if I took out the filename part on save/send, then we wouldn't show the attachment in the attachment area, and I need to fix the content type as well. And then I have to make sure that loading a draft msg with a big file attachment gets the filename from the X-Mozilla-Cloud-Part header...
Assignee | ||
Comment 7•13 years ago
|
||
this makes the cloud part be text/html, and puts in a link, and removes the filename so we won't display it as an attachment in the UI.
Assignee: nobody → dbienvenu
Attachment #610801 -
Flags: review?(mconley)
Comment 8•13 years ago
|
||
Comment on attachment 610801 [details] [diff] [review]
proposed fix
Review of attachment 610801 [details] [diff] [review]:
-----------------------------------------------------------------
This makes sense to me. Good stuff!
Attachment #610801 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 9•13 years ago
|
||
Comment on attachment 610801 [details] [diff] [review]
proposed fix
[Approval Request Comment]
User impact if declined:
cloud file attachments show up as real attachments in attachment pane.
Attachment #610801 -
Flags: approval-comm-aurora?
Updated•13 years ago
|
Attachment #610801 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 10•13 years ago
|
||
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/99876e31f37e
status-thunderbird13:
--- → fixed
Updated•13 years ago
|
Keywords: checkin-needed
Comment 11•13 years ago
|
||
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/477abb7f3627
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in
before you can comment on or make changes to this bug.
Description
•