Sent emails containing a Filelink appear as containing a (fake) attachment

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Message Reader UI
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jb Piacentino, Assigned: Bienvenu)

Tracking

13 Branch
Thunderbird 14.0

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 608025 [details]
Filelink interpreted as attachment

STR

- Create a Filelink
- Send
- Locate it in the Sent folder
- It's presented as if it contained a regular attachment (21 byte long). 

Expected behaviour:
- Do not mark it as containing an attachment.
(Reporter)

Updated

5 years ago
Hardware: x86_64 → All
(Assignee)

Comment 1

5 years ago
they do have an attachment, the html part that describes the file link.
(Reporter)

Comment 2

5 years ago
Ok, fair enough. 

But the attachment is not interpreted as an html part, but rather as the original file type. In the attached screenshot for example, it looks like a jpg file, of 21 bytes size, and TB tries to render it... and fails. That does not seem right, does it ?

Comment 3

5 years ago
Isn't it just that it renders the html part, but the remote image isn't allowed to be shown?
(Assignee)

Comment 4

5 years ago
(In reply to Magnus Melin from comment #3)
> Isn't it just that it renders the html part, but the remote image isn't
> allowed to be shown?

we can't render the remote image - we just have a link to a web page which has a download link somewhere on it...

Comment 5

5 years ago
If I had to guess, it's trying to render the html part as a jpg.
(Assignee)

Comment 6

5 years ago
things are all still a bit of blur after the exciting big files landing. My intent was that the attachments have text/html content-type, but it looks like they have the attachment type of the actual attachment. They've also got Content-Disposition: attachment;
 filename="713645.txt". I think if I took out the filename part on save/send, then we wouldn't show the attachment in the attachment area, and I need to fix the content type as well. And then I have to make sure that loading a draft msg with a big file attachment gets the filename from the X-Mozilla-Cloud-Part header...
(Assignee)

Comment 7

5 years ago
Created attachment 610801 [details] [diff] [review]
proposed fix

this makes the cloud part be text/html, and puts in a link, and removes the filename so we won't display it as an attachment in the UI.
Assignee: nobody → dbienvenu
Attachment #610801 - Flags: review?(mconley)
Comment on attachment 610801 [details] [diff] [review]
proposed fix

Review of attachment 610801 [details] [diff] [review]:
-----------------------------------------------------------------

This makes sense to me.  Good stuff!
Attachment #610801 - Flags: review?(mconley) → review+
(Assignee)

Comment 9

5 years ago
Comment on attachment 610801 [details] [diff] [review]
proposed fix

[Approval Request Comment]

User impact if declined: 
cloud file attachments show up as real attachments in attachment pane.
Attachment #610801 - Flags: approval-comm-aurora?
Attachment #610801 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/99876e31f37e
status-thunderbird13: --- → fixed

Updated

5 years ago
Keywords: checkin-needed
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/477abb7f3627
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0

Updated

5 years ago
Blocks: 698925
You need to log in before you can comment on or make changes to this bug.