2.23 KB, patch
|Details | Diff | Splinter Review|
If the nsLocalFileWin has to resolve a symlink (shortcut), it will call CoCreateInstance. This call should be moved into startup code.
Created attachment 29040 [details] [diff] [review] Move CoCreateInstance into nsLocalFile startup code.
chris, can i get a r/sr on this simple patch. It will only speed localfiles on windows up when there is a FNF condition.
+#ifdef XP_WIN + CoInitialize(NULL); // FIX: we should probably move somewhere higher up during startup +#endif Uh, that's what you did, right? Or do you still want to move it *earlier*? +#ifdef DOUGT_debug + printf("localfile - resolving symlink\n"); +#endif + Do you want to check this in? sr=waterson
Yes, I still think that this should go higher. Maybe the application should do this? But for now, it is much better where it is. Yes, I want the printf. thanks.
Thanks guys. Fixed is in.