Move CoCreateInstance out of the nsLocalFile.

RESOLVED FIXED in mozilla0.9

Status

()

RESOLVED FIXED
18 years ago
18 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Trunk
mozilla0.9
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
If the nsLocalFileWin has to resolve a symlink (shortcut), it will call
CoCreateInstance.  This call should be moved into startup code.
(Assignee)

Comment 1

18 years ago
Created attachment 29040 [details] [diff] [review]
Move CoCreateInstance into nsLocalFile startup code.
(Assignee)

Comment 2

18 years ago
chris, can i get a r/sr on this simple patch.  It will only speed localfiles on
windows up when there is a FNF condition.
Status: NEW → ASSIGNED

Comment 3

18 years ago
+#ifdef XP_WIN
+  CoInitialize(NULL);  // FIX: we should probably move somewhere higher up 
during startup
+#endif

Uh, that's what you did, right? Or do you still want to move it *earlier*?

+#ifdef DOUGT_debug
+    printf("localfile - resolving symlink\n");
+#endif
+

Do you want to check this in?

sr=waterson
(Assignee)

Comment 4

18 years ago
Yes, I still think that this should go higher.  Maybe the application should do 
this?  But for now, it is much better where it is.

Yes, I want the printf.  

thanks.

(Assignee)

Updated

18 years ago
Target Milestone: --- → mozilla0.9

Comment 5

18 years ago
r=darin
(Assignee)

Comment 6

18 years ago
Thanks guys.  Fixed is in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.