73804 - JavaScript error, after selecting a submenu item in context menu.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[nhottanscp]

I am getting a following error when I select a sub menu item in context menu.
"JavaScript error: line 0: contextMenu has no properties"

Selecting non submenu item like "test2" does not cause the error but the submenu 
item like "test11" always causes the JS error.

  <popupset id="contentAreaContextSet">
    <popup id="contentAreaContextMenu">
      <menu label="test1">
       <menupopup>
          <menuitem label="test11" />
       </menupopup>
       </menu>
      <menuitem label="test2" />
      <menuseparator />
    </popup>
  </popupset>

Comment 1

[Mike Pinkerton (not reading bugmail)]

there could be some problem with /xpfe/communicator/resources/content/
contentAreaContextOverlay.xul, since that's the only thing I can see that 
references |contextMenu|.

editor has submenus in context menus, and i see no js errors there.

-->blake

Comment 2

[Blake Ross]

Do you still see this?

Comment 3

[Blake Ross]

Naoki, are you still able to reproduce this?

Comment 4

[nhottanscp]

Yes, I see it with the patch in bug 70830.
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=28959

Comment 5

[[e-mail] (away - not reading bugmail)]

I tracked this down to the onDestroy method of the nsContextMenu function 
prototype (class):

http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/nsCo
ntextMenu.js#57

I will attempt to resolve this today, if blake or any other of the original 
authors had a look, it would be greatly appreciated.

Comment 6

[Blake Ross]

Attachment: workaround

Comment 7

[Blake Ross]

The real fix is for onpopuphiding and onpopupshowing to not bubble, but this 
will suffice for now. Fixed.

Comment 8

[Bill Law]

Blake, there's a stray ' character inserted in that patch (one of the hunks near
the end).

Also, could you split out the disabled="true" attribute to a separate line to
help preserve the beautifully arranged xul :-).