Noise in the error console due to broken CSS when opening the preference window (in Test pilot)

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
General
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: aceman)

Tracking

Trunk
Thunderbird 14.0
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird12 fixed, thunderbird13 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.89 KB, patch
aceman
: review+
Details | Diff | Splinter Review
Warning: Expected declaration but found '/'.  Skipped to next declaration.
Source File: chrome://messenger/skin/preferences/preferences.css
Line: 207

The offending code is:

204 #providerForm label{
205   width: 75px;
206   text-align: right;
207 //  padding-right: 3px; ???
208 }

Line 207 should be removed, and a space is missing before { on line 204.

http://mxr.mozilla.org/comm-central/source/mail/themes/qute/mail/preferences/preferences.css#161
http://mxr.mozilla.org/comm-central/source/mail/themes/pinstripe/mail/preferences/preferences.css#204
http://mxr.mozilla.org/comm-central/source/mail/themes/gnomestripe/mail/preferences/preferences.css#131
(Assignee)

Comment 1

5 years ago
Created attachment 608111 [details] [diff] [review]
fix
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #608111 - Flags: review?(bwinton)
(Assignee)

Comment 2

5 years ago
I fix the space in the next patch when bwinton decides whether it is better to remove the line 207 or just fix the comment delimiters as I have done in the patch.
Comment on attachment 608111 [details] [diff] [review]
fix

Stealing this review request.
Attachment #608111 - Flags: review?(bwinton) → review?(mconley)
Comment on attachment 608111 [details] [diff] [review]
fix

Review of attachment 608111 [details] [diff] [review]:
-----------------------------------------------------------------

aceman:

Good catches, and an easy review.

The stuff in themes/*/preferences.css should be excised, since bug 739279 will take care of it, and I don't really want it to get bitrotted.

With the changes to the preferences.css files removed, this is r=me.

::: mail/themes/gnomestripe/mail/preferences/preferences.css
@@ +130,5 @@
>  
>  #providerForm label{
>    width: 150px;
>    text-align: right;
> +/*  padding-right: 3px; ??? */

The patch for bug 739279 will take care of this.  To prevent bitrotting it, let's omit the changes to themes/*/preferences.css for now.
Attachment #608111 - Flags: review?(mconley) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 613710 [details] [diff] [review]
fix v2

r=mconley.
Attachment #608111 - Attachment is obsolete: true
Attachment #613710 - Flags: review+

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

5 years ago
Considering the patch is now completely different to the original description, let's move it to the Test pilot component.
Component: Theme → Test Pilot
Product: Thunderbird → Mozilla Labs
QA Contact: theme → test-pilot
Summary: Noise in the error console due to broken CSS when opening the preference window → Noise in the error console due to broken CSS when opening the preference window (in Test pilot)
http://hg.mozilla.org/comm-central/rev/523577cb590f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.3
(In reply to :aceman from comment #6)
> Considering the patch is now completely different to the original
> description, let's move it to the Test pilot component.

Please don't at the moment. We're a separate branch to test pilot at the moment and so we're keeping bugs about Thunderbird's version in Thunderbird.
Component: Test Pilot → General
Product: Mozilla Labs → Thunderbird
QA Contact: test-pilot → general
Target Milestone: 1.3 → ---
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 613710 [details] [diff] [review]
fix v2

[Triage Comment]
Taking forward to aurora/beta as this actually fixes an issue with notifications in test pilot being transparent.

I also did a version bump for the in-tree test pilot here:

http://hg.mozilla.org/comm-central/rev/a030c1d42585
Attachment #613710 - Flags: approval-comm-beta+
Attachment #613710 - Flags: approval-comm-aurora+
Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/06383f9e9217
http://hg.mozilla.org/releases/comm-aurora/rev/d1a0eeb209fb
http://hg.mozilla.org/releases/comm-beta/rev/7748e000cbeb
http://hg.mozilla.org/releases/comm-beta/rev/7e631de9f7de
status-thunderbird12: --- → fixed
status-thunderbird13: --- → fixed
(Assignee)

Comment 11

5 years ago
Is that issue filed/discussed anywhere?
You need to log in before you can comment on or make changes to this bug.