Closed Bug 738054 Opened 10 years ago Closed 10 years ago

Setting :focus in DOM pseudoClass dialog doesn't work

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file, 2 obsolete files)

Since Gecko 1.9.2 the focus content state stopped being handled by the ESM and is now handled by the focus manager, and trying to set the focus content state simply doesn't work. However for Gecko 13 a new API was added to inDOMUtils by bug 708874 and this API does work to emulate the focus state.

I don't know whether it's worth disabling the focus checkbox for Gecko 1.9.2 to Gecko 12.
Attached patch Proposed patch (obsolete) — Splinter Review
Rather conveniently the new API uses the same strings as the checkbox labels.

I didn't want to consider adding other strings as that would be out of the scope of this bug.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #608108 - Flags: review?(Sevenspade)
Comment on attachment 608108 [details] [diff] [review]
Proposed patch

Review of attachment 608108 [details] [diff] [review]:
-----------------------------------------------------------------

Brace all control statement bodies, please.
Attachment #608108 - Flags: review?(Sevenspade) → review+
Attached patch Addressed review comments (obsolete) — Splinter Review
I wasn't quite sure what you wanted so I braced some existing code as well.
Attachment #608108 - Attachment is obsolete: true
Attachment #608161 - Flags: review?(Sevenspade)
Comment on attachment 608161 [details] [diff] [review]
Addressed review comments

Review of attachment 608161 [details] [diff] [review]:
-----------------------------------------------------------------

That's what I meant, except with |else| on on a separate line from the |if| closing brace.
Attachment #608161 - Flags: review?(Sevenspade) → review+
}
else {
Attachment #608161 - Attachment is obsolete: true
Attachment #608447 - Flags: review+
Pushed changeset 772494f61v8f to dom-inspector.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.