738054 - Setting :focus in DOM pseudoClass dialog doesn't work

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[[e-mail]]

Since Gecko 1.9.2 the focus content state stopped being handled by the ESM and is now handled by the focus manager, and trying to set the focus content state simply doesn't work. However for Gecko 13 a new API was added to inDOMUtils by bug 708874 and this API does work to emulate the focus state.

I don't know whether it's worth disabling the focus checkbox for Gecko 1.9.2 to Gecko 12.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Rather conveniently the new API uses the same strings as the checkbox labels.

I didn't want to consider adding other strings as that would be out of the scope of this bug.

Comment 2

[Colby Russell :crussell (no longer Mozilla-ing)]

Comment on attachment 608108 [details] [diff] [review]
Proposed patch

Review of attachment 608108 [details] [diff] [review]:
-----------------------------------------------------------------

Brace all control statement bodies, please.

Comment 3

[[e-mail]]

Attachment: Addressed review comments

I wasn't quite sure what you wanted so I braced some existing code as well.

Comment 4

[Colby Russell :crussell (no longer Mozilla-ing)]

Comment on attachment 608161 [details] [diff] [review]
Addressed review comments

Review of attachment 608161 [details] [diff] [review]:
-----------------------------------------------------------------

That's what I meant, except with |else| on on a separate line from the |if| closing brace.

Comment 5

[[e-mail]]

Attachment: Addressed review comments

}
else {

Comment 6

[[e-mail]]

Pushed changeset 772494f61v8f to dom-inspector.