Clicking tab close button in inactive window on OS X should close tab

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: fryn, Assigned: fryn)

Tracking

({ux-consistency})

Trunk
Firefox 15
All
Mac OS X
ux-consistency
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 608147 [details] [diff] [review]
patch

It was believed that the UI precedent on OS X was to disable tab close buttons in inactive windows on OS X. However, other applications on OS X, including but not limited to Safari, Chrome, and Terminal, do not disable the tab close buttons in inactive windows, and neither should we.
Attachment #608147 - Flags: ui-review?(limi)
Attachment #608147 - Flags: review?(gavin.sharp)
ref bug 392188 comment 27
Attachment #608147 - Flags: review?(gavin.sharp) → review+
Attachment #608147 - Flags: ui-review?(limi) → ui-review+
Whiteboard: [autoland-try:-b o -p linux,macosx64,win32 -u none -t none]

Updated

5 years ago
Whiteboard: [autoland-try:-b o -p linux,macosx64,win32 -u none -t none] → [autoland-in-queue]

Comment 2

5 years ago
Autoland Patchset:
	Patches: 608147
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=65e3873b0dfb
Try run started, revision 65e3873b0dfb. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=65e3873b0dfb

Comment 3

5 years ago
Try run for 65e3873b0dfb is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=65e3873b0dfb
Results (out of 3 total builds):
    success: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-65e3873b0dfb
Whiteboard: [autoland-in-queue]
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/6aa19c67af2f
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/6aa19c67af2f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15
You need to log in before you can comment on or make changes to this bug.