738203 - "You're running an unknown version of Firefox"

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Derek Williams]

Attachment: Screen Shot 2012-03-22 at 11.12.11.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20100101 Firefox/12.0
Build ID: 20120314195616

Steps to reproduce:

I opened the lid of my sleeping MacBook Pro laptop, with Firefox 12 still active.


Actual results:

I saw this message out of the blue, the first time I ever had it, and since the latest 12 beta got auto-installed.


Expected results:

Firefox should not flag a beta version as "unknown". It never has before to my knowledge or recollection.

Comment 1

[Derek Williams]

Attachment: "get latest version"

tells me I am up to date while at the same time offering a link to download the latest version

Comment 2

[Derek Williams]

Attachment: offers v.11 as a later version than 12

even though v.12 is running, I am offered v.11

Comment 3

[Marcia Knous [:marcia]]

Confirming, I have this as well today on two different machines. Moving to websites.

Comment 4

[Marcia Knous [:marcia]]

I am seeing this running Firefox 12 B2.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Can you list specific steps to reproduce, including URLs?

I'll make sure this gets covered manually after being fixed, and then we can do automation.  Thanks!

Comment 6

[Marcia Knous [:marcia]]

Let me try to get some STR. One thing I wanted to mention is that I might have been using different profiles when testing (using an aurora profile launch beta, for example)

Comment 7

[Marcia Knous [:marcia]]

STR:

1. Download Firefox 12B3 from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/12.0b3-candidates/build1/mac/en-US/
2. Launch the build with an existing Nightly Profile
3. Receive the unknown version page

If I launch with a new profile I get the correct page.

Comment 8

[Matthew N. [:MattN]]

I had a Firefox 11 (Release) profile and download Firefox 12 (Beta) and saw the what's new page on first run of 12.

Comment 9

[Marcia Knous [:marcia]]

Cheng reported in the Channel Meeting that there is trending going on indicating users are hitting this: see https://wiki.mozilla.org/Firefox/Channels/Meetings/2012-04-10#Roundtable

Comment 10

[Alex Keybl [:akeybl]]

I suspect this is a problem in the .htaccess file. This is part of the reason I filed bug 736934 to make updating the applicable sites less of a minefield.

James - would you mind taking a look? STR for your purposes would be

1) Download and install the build at https://www.mozilla.org/en-US/firefox/beta/
2) Go to http://www.mozilla.org/en-US/firefox/12.0/whatsnew/

Expected result: the page should not show "You're running an unknown version of Firefox"

Comment 11

[James Long (:jlongster)]

(In reply to Alex Keybl [:akeybl] from comment #10)
> I suspect this is a problem in the .htaccess file. This is part of the
> reason I filed bug 736934 to make updating the applicable sites less of a
> minefield.
> 
> James - would you mind taking a look? STR for your purposes would be
> 
> 1) Download and install the build at
> https://www.mozilla.org/en-US/firefox/beta/
> 2) Go to http://www.mozilla.org/en-US/firefox/12.0/whatsnew/
> 
> Expected result: the page should not show "You're running an unknown version
> of Firefox"

This is not an .htaccess issue, it's an issue that runs deeper to the sloppiness of the PHP site.

Two things at play:

* There's a function `isValidVersionByReleaseNotes` called by the page to see if the version is valid. This works by checking of the  file /firefox/<version>/releasenotes exists. Yuck. It didn't exists because the version string was 11.0 and the filesystem folder is 11.0beta.

* There's a check to see if the versions are *equal* in that whatsnew PHP code. I changed it to check is it is less than.

Fixes are committed in r104174

If you test this on the www-dev site, and verify, I can push that out.

Comment 12

[raymond [:retornam] (inactive)]

(In reply to James Long (:jlongster) from comment #11)
> (In reply to Alex Keybl [:akeybl] from comment #10)
> > I suspect this is a problem in the .htaccess file. This is part of the
> > reason I filed bug 736934 to make updating the applicable sites less of a
> > minefield.
> > 
> > James - would you mind taking a look? STR for your purposes would be
> > 
> > 1) Download and install the build at
> > https://www.mozilla.org/en-US/firefox/beta/
> > 2) Go to http://www.mozilla.org/en-US/firefox/12.0/whatsnew/
> > 
> > Expected result: the page should not show "You're running an unknown version
> > of Firefox"
> 
> This is not an .htaccess issue, it's an issue that runs deeper to the
> sloppiness of the PHP site.
> 
> Two things at play:
> 
> * There's a function `isValidVersionByReleaseNotes` called by the page to
> see if the version is valid. This works by checking of the  file
> /firefox/<version>/releasenotes exists. Yuck. It didn't exists because the
> version string was 11.0 and the filesystem folder is 11.0beta.
> 
> * There's a check to see if the versions are *equal* in that whatsnew PHP
> code. I changed it to check is it is less than.
> 
> Fixes are committed in r104174
> 
> If you test this on the www-dev site, and verify, I can push that out.

Works fine on Firefox 11 and Nightly http://www-dev.allizom.org/en-US/firefox/12.0/whatsnew/ but visiting in Chrome and Safari now says you have an updated version of Firefox instead of You’re running an unknown version of Firefox.

Comment 13

[raymond [:retornam] (inactive)]

Attachment: screenshot

Comment 14

[Fred Wenzel [:wenzel]]

Unassigning bugs from James that are not migration-related bedrock platform bugs. Let me know if you have any questions.

Comment 15

[Derek Williams]

Attachment: 1/3 said "update failed" and gave link to download

Comment 16

[Derek Williams]

Attachment: 2/3 took me to page with link to download "latest version"

Comment 17

[Derek Williams]

Attachment: 3/3 "latest" version 11 is offered as more up to date than beta 12

Comment 18

[James Long (:jlongster)]

Derek, that's actually out of scope for this bug. The "download latest version" link in the about panel simply is hardcoded to /firefox/fx, which will always point to the latest release version, not any beta or other version.

If you want that workflow to work, the link in the about panel needs to be a lot smarter.

Comment 19

[Alex Keybl [:akeybl]]

(In reply to James Long (:jlongster) from comment #11)
> Fixes are committed in r104174
> 
> If you test this on the www-dev site, and verify, I can push that out.

Didn't realize this was on hold. I've verified that I now get "Hooray! Your Firefox is up to date." on [1]. Let's push out the fix today in preparation for tomorrow's release.

[1] https://www-dev.allizom.org/en-US/firefox/12.0/whatsnew/

Comment 20

[James Long (:jlongster)]

Sounds good. Raymond, from what I see in the code, that's always happened and I guess it's ok because it's the whatsnew page and should never be hit by other browsers.

Taking this bug back since it's already done.

Comment 21

[James Long (:jlongster)]

pushed to production r104681

Comment 22

[David Lawrence [:dkl]]

Restoring unintended removal of in-testsuite flag.