If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

"OOPS! We had an error" page displayed after adding an extension to favorites and opening My Favorites collection.

VERIFIED FIXED

Status

addons.mozilla.org Graveyard
Collections
VERIFIED FIXED
6 years ago
2 years ago

People

(Reporter: Victor Carciu, Unassigned)

Tracking

({regression})

Details

(URL)

(Reporter)

Description

6 years ago
Prerequisites:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0

Steps to reproduce:


Please see screencast for this bug : http://screencast.com/t/RqLfJM4b0Ukv
(Reporter)

Comment 1

6 years ago
Pressed enter by mistake...You can see the bug description below:

Steps to reproduce:
1.Login to AMO homepage: https://addons-dev.allizom.org/en-US/firefox/
2.Open any addon listed in homepage(i.e. AdblockPlus : https://addons-dev.allizom.org/en-US/firefox/addon/adblock-plus/?src=hp-dl-mostpopular)
3.Click the "Add to favorites" link from right side of the addon detail page.
4.From Collections dropdown menu, select "My Favorite Add-ons"

Expected results:
My Favorite Add-ons collection is opened without any issue and the extension added at step 3 is displayed.

Actual Results:
"Oops! We had an error." we had an error page is displayed and the collection cannot be opened until we remove the add-on added at step 3 from favorites.

Please see screencast for this bug : http://screencast.com/t/RqLfJM4b0Ukv

NOTES:
1.Not reproducible for Personas
2.Not reproducible in production.
Keywords: regression
Summary: "OOPS" page displayed → "OOPS! We had an error" page displayed after adding an extension to favorites and opening My Favorites collection.
Looks fine to me: https://addons-dev.allizom.org/en-US/firefox/collections/moztest1/favorites/

The add-ons listed in your Favorites appear to have been cached. I can't reproduce this. If you can, please do reopen.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME
For reference:

Traceback (most recent call last):

 File "/data/www/addons-dev.allizom.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
   response = callback(request, *callback_args, **callback_kwargs)

 File "/data/www/addons-dev.allizom.org/zamboni/apps/bandwagon/views.py", line 216, in collection_detail
   'user_perms': user_perms})

 File "/data/www/addons-dev.allizom.org/zamboni/apps/bandwagon/views.py", line 113, in render
   return jingo.render(request, template, data, **extra)

 File "/data/www/addons-dev.allizom.org/zamboni/vendor/src/jingo/jingo/__init__.py", line 80, in render
   rendered = render_to_string(request, template, context)

 File "/data/www/addons-dev.allizom.org/zamboni/vendor/src/jingo/jingo/__init__.py", line 98, in render_to_string
   return template.render(**get_context())

 File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/www/addons-dev.allizom.org/zamboni/apps/bandwagon/templates/bandwagon/collection_detail.html", line 213, in top-level template code
   <p>{{ _('My favorite add-ons') }}</p>

 File "/data/www/addons-dev.allizom.org/zamboni/templates/base.html", line 112, in top-level template code
   {% block main_content %}

 File "/data/www/addons-dev.allizom.org/zamboni/templates/base.html", line 115, in block "main_content"
   {% block content %}{% endblock %}

 File "/data/www/addons-dev.allizom.org/zamboni/apps/bandwagon/templates/bandwagon/collection_detail.html", line 104, in block "content"
   {% cache addons.object_list %}

 File "/data/www/addons-dev.allizom.org/zamboni/apps/amo/ext.py", line 18, in _cache_support
   return caller()

 File "/data/www/addons-dev.allizom.org/zamboni/apps/bandwagon/templates/bandwagon/collection_detail.html", line 114, in template
   {{ persona_grid(addons.object_list) }}

 File "/data/www/addons-dev.allizom.org/zamboni/vendor/src/jingo/jingo/__init__.py", line 148, in wrapper
   t = env.get_template(template).render(context)

 File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render
   return self.environment.handle_exception(exc_info, True)

 File "/data/www/addons-dev.allizom.org/zamboni/apps/addons/templates/addons/persona_grid.html", line 2, in top-level template code
   {% cache addons %}

 File "/data/www/addons-dev.allizom.org/zamboni/apps/amo/ext.py", line 18, in _cache_support
   return caller()

 File "/data/www/addons-dev.allizom.org/zamboni/apps/addons/templates/addons/persona_grid.html", line 5, in template
   {{ persona_preview(addon.persona, size='small', details=True) }}

 File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 371, in getattr
   return getattr(obj, attribute)

 File "/data/www/addons-dev.allizom.org/zamboni/vendor/src/django/django/db/models/fields/related.py", line 240, in __get__
   rel_obj = self.related.model._base_manager.using(db).get(**params)

 File "/data/www/addons-dev.allizom.org/zamboni/vendor/src/django/django/db/models/query.py", line 349, in get
   % self.model._meta.object_name)

DoesNotExist: Persona matching query does not exist.


<WSGIRequest
GET:<QueryDict: {}>,
POST:<QueryDict: {}>,
COOKIES:{'mamo': 'off', 'multidb_pin_writes': 'y', 'sessionid': '******'},
META:{'DOCUMENT_ROOT': '/data/www/addons-dev.allizom.org-remora/site/app/webroot',
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTPS': 'on',
'HTTP_ACCEPT': 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
'HTTP_ACCEPT_LANGUAGE': 'en-us,en;q=0.5',
'HTTP_CONNECTION': 'keep-alive',
'HTTP_COOKIE': '******',
'HTTP_HOST': 'addons-dev.allizom.org',
'HTTP_REFERER': 'https://addons-dev.allizom.org/en-US/firefox/collections/moztest1/favorites/edit/',
(Reporter)

Comment 4

6 years ago
Still reproducible using the original scenario.
Still reproducible after 15 minutes and after a sign out\ sign in action.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Bug is 18 months old.  We've had a lot of improvements in this area (including moving all personas to AMO).  Assuming this is fixed.
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

4 years ago
Verified as fixed: http://screencast.com/t/lzaxY96R
Status: RESOLVED → VERIFIED
(Assignee)

Updated

2 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.