Closed Bug 738241 Opened 10 years ago Closed 10 years ago

Filelink account setup providers menulist should contain their respective icons


(Thunderbird :: Preferences, defect)

13 Branch
Not set


(thunderbird13 fixed)

Thunderbird 14.0
Tracking Status
thunderbird13 --- fixed


(Reporter: jb, Assigned: mconley)




(4 files, 2 obsolete files)

Currently, the list only makes reference to the providers name. 
However, once a provider is selected, its icon is displayed.
Assignee: nobody → mconley
Blocks: BigFiles
Attached patch WIP Patch 1 (obsolete) — Splinter Review
Got it working for Windows, stashing my work here to make sure it works on OSX and Ubuntu...
Attached patch Patch v1 (obsolete) — Splinter Review
Ok, I've copied the CSS for both pinstripe and gnomestripe.

I still don't see the icons on Ubuntu - but I think this is a toolkit limitation.  Firefox does the same thing in the Feed Subscribe page.  Go to for example, and click on the "Subscribe to this feed using" icons there either on Ubuntu, but they exist on OSX and Windows.  So I think we might have to punt there.

I'm just going to test this patch on OSX (which originally worked, but I'm copying the CSS over for consistency).
Attachment #608756 - Attachment is obsolete: true
Comment on attachment 608767 [details] [diff] [review]
Patch v1


Ok, here's my solution.  Does it make sense?  Also, I noticed we've got some styles specific to the addAccountDialog stuffed into preferences.css that we should probably move into addAccountDialog.css.  I've filed bug 738699 about that.

Attachment #608767 - Flags: review?(nisses.mail)
Sounds like you probably need the menuitem-with-favicon class if you want to see the icons on Ubuntu

Comment on attachment 608767 [details] [diff] [review]
Patch v1

Chris Coulson just told me how I might get icons to display in Ubuntu - going to try that, and will update patch if it works.
Attachment #608767 - Flags: review?(nisses.mail)
Attached patch Patch v2Splinter Review
This patch works across all three platforms.  Woo!
Attachment #608767 - Attachment is obsolete: true
Attachment #608810 - Flags: review?(nisses.mail)
Attachment #608810 - Flags: review?(nisses.mail) → review?(bwinton)
Comment on attachment 608810 [details] [diff] [review]
Patch v2

Screenshots en-route
Attachment #608810 - Flags: ui-review?(bwinton)
Comment on attachment 608810 [details] [diff] [review]
Patch v2

>+++ b/mail/components/cloudfile/content/addAccountDialog.js
>@@ -95,17 +95,17 @@ let addAccountDialog = {
>       if (provider.iconClass) {
>-        menuitem.setAttribute("class", "menuitem-iconic");
>+        menuitem.setAttribute("class", "menuitem-iconic menuitem-with-favicon");
>         menuitem.setAttribute("image", provider.iconClass);
>       }

Huh, so we were always setting the image, but it wasn't showing up?  Cool.

In either case, it looks good, so r=me, and ui-r=me.

Attachment #608810 - Flags: ui-review?(bwinton)
Attachment #608810 - Flags: ui-review+
Attachment #608810 - Flags: review?(bwinton)
Attachment #608810 - Flags: review+
Attached image Provider icons in OSX
Here's the last one.
Comment on attachment 608810 [details] [diff] [review]
Patch v2

We'll want this for 13.
Attachment #608810 - Flags: approval-comm-aurora?
Committed to comm-central as
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
OS: Windows 7 → All
Attachment #608810 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.