Filelink account setup providers menulist should contain their respective icons

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Preferences
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jb Piacentino, Assigned: mconley)

Tracking

13 Branch
Thunderbird 14.0

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
Currently, the list only makes reference to the providers name. 
However, once a provider is selected, its icon is displayed.
(Reporter)

Updated

6 years ago
Assignee: nobody → mconley
Blocks: 698925
Created attachment 608756 [details] [diff] [review]
WIP Patch 1

Got it working for Windows, stashing my work here to make sure it works on OSX and Ubuntu...
Created attachment 608767 [details] [diff] [review]
Patch v1

Ok, I've copied the CSS for both pinstripe and gnomestripe.

I still don't see the icons on Ubuntu - but I think this is a toolkit limitation.  Firefox does the same thing in the Feed Subscribe page.  Go to http://www.mikeconley.ca/blog/feed for example, and click on the "Subscribe to this feed using"...no icons there either on Ubuntu, but they exist on OSX and Windows.  So I think we might have to punt there.

I'm just going to test this patch on OSX (which originally worked, but I'm copying the CSS over for consistency).
Attachment #608756 - Attachment is obsolete: true
Comment on attachment 608767 [details] [diff] [review]
Patch v1

Andreas:

Ok, here's my solution.  Does it make sense?  Also, I noticed we've got some styles specific to the addAccountDialog stuffed into preferences.css that we should probably move into addAccountDialog.css.  I've filed bug 738699 about that.

-Mike
Attachment #608767 - Flags: review?(nisses.mail)

Comment 4

6 years ago
Sounds like you probably need the menuitem-with-favicon class if you want to see the icons on Ubuntu

see http://hg.mozilla.org/mozilla-central/file/d41503780635/toolkit/content/xul.css#l367
Comment on attachment 608767 [details] [diff] [review]
Patch v1

Chris Coulson just told me how I might get icons to display in Ubuntu - going to try that, and will update patch if it works.
Attachment #608767 - Flags: review?(nisses.mail)
Created attachment 608810 [details] [diff] [review]
Patch v2

This patch works across all three platforms.  Woo!
Attachment #608767 - Attachment is obsolete: true
Attachment #608810 - Flags: review?(nisses.mail)
Attachment #608810 - Flags: review?(nisses.mail) → review?(bwinton)
Comment on attachment 608810 [details] [diff] [review]
Patch v2

Screenshots en-route
Attachment #608810 - Flags: ui-review?(bwinton)
Created attachment 608852 [details]
Provider icons in Windows 7
Created attachment 608854 [details]
Provider icons in Ubuntu
Comment on attachment 608810 [details] [diff] [review]
Patch v2

>+++ b/mail/components/cloudfile/content/addAccountDialog.js
>@@ -95,17 +95,17 @@ let addAccountDialog = {
>       if (provider.iconClass) {
>-        menuitem.setAttribute("class", "menuitem-iconic");
>+        menuitem.setAttribute("class", "menuitem-iconic menuitem-with-favicon");
>         menuitem.setAttribute("image", provider.iconClass);
>       }

Huh, so we were always setting the image, but it wasn't showing up?  Cool.

In either case, it looks good, so r=me, and ui-r=me.

Thanks,
Blake.
Attachment #608810 - Flags: ui-review?(bwinton)
Attachment #608810 - Flags: ui-review+
Attachment #608810 - Flags: review?(bwinton)
Attachment #608810 - Flags: review+
Created attachment 608855 [details]
Provider icons in OSX

Here's the last one.
Comment on attachment 608810 [details] [diff] [review]
Patch v2

We'll want this for 13.
Attachment #608810 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/c2e492105d6d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0

Updated

6 years ago
OS: Windows 7 → All
Attachment #608810 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/b93d8d423cc0
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.