Filelink account setup dialog fro YouSendIt is not nicely aligned

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Preferences
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jb Piacentino, Assigned: mconley)

Tracking

13 Branch
Thunderbird 14.0
x86_64
Windows 7

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 608327 [details]
'Need an account' not aligned

It would be nicer to have the 'Need an acount' text aligned with the menulist, and spaced one line below.
(Assignee)

Updated

6 years ago
Blocks: 698925
(Assignee)

Comment 1

6 years ago
Created attachment 608850 [details] [diff] [review]
Patch v1

Looks like we forgot to bring some CSS over into qute.

This look OK Andreas?
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Attachment #608850 - Flags: review?(nisses.mail)
(Assignee)

Comment 2

6 years ago
Comment on attachment 608850 [details] [diff] [review]
Patch v1

Redirecting to bwinton
Attachment #608850 - Flags: review?(nisses.mail) → review?(bwinton)
(Assignee)

Comment 3

6 years ago
Comment on attachment 608850 [details] [diff] [review]
Patch v1

Screenshot coming up
Attachment #608850 - Flags: ui-review?(bwinton)
(Assignee)

Comment 4

6 years ago
Created attachment 608853 [details]
Fixed YouSendIt "Need an Account?" alignment
Comment on attachment 608850 [details] [diff] [review]
Patch v1

I think we want a little more padding in between the various things but you can change that before you check it in.

So r=me, and ui-r=me with that nit fixed.

Thanks,
Blake.
Attachment #608850 - Flags: ui-review?(bwinton)
Attachment #608850 - Flags: ui-review+
Attachment #608850 - Flags: review?(bwinton)
Attachment #608850 - Flags: review+
(Assignee)

Comment 6

6 years ago
Comment on attachment 608850 [details] [diff] [review]
Patch v1

As discussed with Blake IRL, we're going to land this patch now, and take care of those YouSendIt padding issues in a separate bug (bug 739279).
Attachment #608850 - Flags: approval-comm-aurora?
(Assignee)

Comment 7

6 years ago
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/6088417632b4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
(Assignee)

Comment 8

6 years ago
Just a note that this fix is being mostly overwritten by bug 739279.  We can save ourselves some conflicts/merging headaches if this lands on comm-aurora before bug 739279 does.
Attachment #608850 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 9

6 years ago
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/89b4aee905d2
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.