738243 - Filelink account setup dialog fro YouSendIt is not nicely aligned

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Jb Piacentino]

Attachment: 'Need an account' not aligned

It would be nicer to have the 'Need an acount' text aligned with the menulist, and spaced one line below.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Looks like we forgot to bring some CSS over into qute.

This look OK Andreas?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 608850 [details] [diff] [review]
Patch v1

Redirecting to bwinton

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 608850 [details] [diff] [review]
Patch v1

Screenshot coming up

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Fixed YouSendIt "Need an Account?" alignment

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 608850 [details] [diff] [review]
Patch v1

I think we want a little more padding in between the various things but you can change that before you check it in.

So r=me, and ui-r=me with that nit fixed.

Thanks,
Blake.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 608850 [details] [diff] [review]
Patch v1

As discussed with Blake IRL, we're going to land this patch now, and take care of those YouSendIt padding issues in a separate bug (bug 739279).

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/6088417632b4

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Just a note that this fix is being mostly overwritten by bug 739279.  We can save ourselves some conflicts/merging headaches if this lands on comm-aurora before bug 739279 does.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/89b4aee905d2