navigator.mozApps.mgmt.getAll() doesn't handle non-ASCII characters in the manifest

VERIFIED FIXED in mozilla17

Status

()

Core
DOM: Apps
--
major
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: djf, Assigned: fabrice)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(blocking-kilimanjaro:+, blocking-basecamp:+)

Details

(Whiteboard: [qa!])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
When I use navigator.mozApps.mgmt.getAll() in the Gaia homescreen, and set the local to French, accented characters in the app name are garbled.  It appears that UTF-8 strings in the manifest are being treated as 7-bit ASCII and not properly converted into JavaScript UTF-16 strings.
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
As a point of similarity, this issue also occurs with desktop native installation (see bug 733482). Seeing that this happens in more than spot makes me think that this UTF-8 character issue could be more areas we have not looked at yet.

Comment 2

5 years ago
We should definitely include some non-ASCII manifests in our testing (right now all our test manifests are strictly ASCII).

Updated

5 years ago
See Also: → bug 733482
Hey jason I had written a manual test with japanese characters. 

In the interim, could you add this test to your smoketest. 

https://github.com/mozilla/openwebapps/tree/develop/site/tests/apps/app3
To do that you need to run the node test server, and load appstore.html

the above app will be listed to be installed, and you should be able to install to the dashboard, view on dashboard..etc
Yup, I've added the UTF-8 character test on native install here on test case IA-15 (https://docs.google.com/spreadsheet/ccc?key=0AiZoGR-iOAlUdDdfMHo5aTI2WjVIeWxnNWxvV0ZVOWc#gid=0).

Comment 6

5 years ago
I you post the manifest somewhere I can add it to the /appdir/ list
ian that touches on another issue which is where / how to host test apps ......

I think the staging server would be a good spot for this, the question is whether we can get ops to open some firewall ports so we can run the node.js test server. 

i think that would be optimal

Comment 8

5 years ago
I think appengine or heroku might be better hosting options for samples.
Filed bug 738845 for the hosting of test apps. Let's pull the conversation on the test case applications over to that bug.
Jason, do you have an eta on this bug fix ?
Which bug are you referring to? This one? Bug 738845? If it's bug 738845, please comment in that bug.
I was referring to this bug.
This is an implementation bug - I'm not the appropriate person to fix this bug.
k, wanted to determine if you had more information about the bug than I did... 

Fabrice: do you have an eta on this bug fix ?
(Assignee)

Comment 15

5 years ago
I'll probably have a fix by the end of next week

Updated

5 years ago
Assignee: fabrice → nobody
Component: General → DOM: Mozilla Extensions
Product: Web Apps → Core
QA Contact: general → general
Whiteboard: [mozappsapi]
Whiteboard: [mozappsapi] → [mozApps API 1.0]

Updated

5 years ago
Whiteboard: [mozApps API 1.0] → [mozApps API 1.0] [marketplace-beta?]

Updated

5 years ago
Whiteboard: [mozApps API 1.0] [marketplace-beta?] → [mozApps API 1.0]

Updated

5 years ago
Blocks: 746465

Updated

5 years ago
Whiteboard: [mozApps API 1.0]
Nominating for k9o - this affects localized b2g apps
blocking-kilimanjaro: --- → ?

Updated

5 years ago
blocking-kilimanjaro: ? → +

Updated

5 years ago
No longer blocks: 746465
Component: DOM: Mozilla Extensions → DOM: Apps

Updated

5 years ago
blocking-basecamp: --- → ?
blocking-basecamp: ? → +

Updated

5 years ago
Assignee: nobody → fabrice
(Assignee)

Comment 17

5 years ago
Created attachment 647477 [details] [diff] [review]
patch

Tested by changing some manifest.webapp files in gaia to use utf-8 instead of the current escaping.
Attachment #647477 - Flags: review?(21)
Comment on attachment 647477 [details] [diff] [review]
patch

Review of attachment 647477 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #647477 - Flags: review?(21) → review+
(Assignee)

Comment 19

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bef20dfc8fb

Updated

5 years ago
QA Contact: jsmith
Whiteboard: [qa+]
https://hg.mozilla.org/mozilla-central/rev/2bef20dfc8fb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Testing on desktop, this looks okay outside of the regression that was caught on Android. I'll want to test this on Firefox OS though to be sure.
(Assignee)

Comment 22

5 years ago
(In reply to Jason Smith [:jsmith] from comment #21)
> Testing on desktop, this looks okay outside of the regression that was
> caught on Android. I'll want to test this on Firefox OS though to be sure.

Which android regression?
(In reply to Fabrice Desré [:fabrice] from comment #22)
> (In reply to Jason Smith [:jsmith] from comment #21)
> > Testing on desktop, this looks okay outside of the regression that was
> > caught on Android. I'll want to test this on Firefox OS though to be sure.
> 
> Which android regression?

bug 779490
Verified on 8/6/2012 Firefox OS Daily Build with Ed Lee's app with Japanese characters.
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
You need to log in before you can comment on or make changes to this bug.