disable building docs for libunwind so b2g starts building again (follow on to bug 683229)

RESOLVED FIXED in mozilla14

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jhford, Assigned: Ehsan)

Tracking

(Depends on: 1 bug)

unspecified
mozilla14
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

libunwind is trying to build its documentation.  Unless we need this documentation, we should disable building the documentation because building it wastes time and introduces new build time dependencies that aren't otherwise useful or desirable.

This means that our B2G builds that are about to go live in production aren't building anymore.

make[7]: Leaving directory `/builds/slave/m-cen-b2g/build/obj-b2g/tools/profiler/libunwind/src/tests'
Making all in doc
make[7]: Entering directory `/builds/slave/m-cen-b2g/build/obj-b2g/tools/profiler/libunwind/src/doc'
latex2man -t /builds/slave/m-cen-b2g/build/tools/profiler/libunwind/src/doc/libunwind.trans /builds/slave/m-cen-b2g/build/tools/profiler/libunwind/src/doc/unw_get_proc_info_by_ip.tex unw_get_proc_info_by_ip.man
make[7]: latex2man: Command not found
make[7]: *** [unw_get_proc_info_by_ip.man] Error 127
make[7]: Leaving directory `/builds/slave/m-cen-b2g/build/obj-b2g/tools/profiler/libunwind/src/doc'
make[6]: *** [all-recursive] Error 1
this means that b2g is building with profiling enabled. Is that expected?
(In reply to Benoit Girard (:BenWa) from comment #1)
> this means that b2g is building with profiling enabled. Is that expected?

According to the mozconfig given to me by the b2g team, yes

http://hg.mozilla.org/mozilla-central/file/default/b2g/config/mozconfigs/linux32/debug
Assignee: nobody → ehsan
Component: General → Gecko Profiler
QA Contact: general → gecko-profiler
libunwind itself does not support building without documentation, but we may be able to trick it somehow...
Created attachment 608471 [details] [diff] [review]
Patch (v1)

This is a hack, but I think not a very bad one, in that we don't need to modify libunwind at all.  The way that this patch works is that it replaces the commands in the docs Makefile (the one in the objdir) with echo so that they won't do anything useful.
Attachment #608471 - Flags: review?(bgirard)

Updated

5 years ago
Attachment #608471 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/51a252a832b9
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/51a252a832b9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 745165
You need to log in before you can comment on or make changes to this bug.