Closed Bug 738326 Opened 12 years ago Closed 12 years ago

Writing pixels to map file takes too long

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 14

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file)

Attached patch chops the getPaintedSurface() execution time from ~90 seconds to ~1 second. Also threw in a couple of other minor things (print the stack trace if we get an exception, and ensure we don't open the pixels.map in the PaintedSurface constructor until after we're done flushing/closing the streams).
Attachment #608371 - Flags: review?(jmaher)
Comment on attachment 608371 [details] [diff] [review]
Buffer output stream

Review of attachment 608371 [details] [diff] [review]:
-----------------------------------------------------------------

so simple to speed this up.  Guess this is what I get for not being a java programmer :)
Attachment #608371 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #1)
> so simple to speed this up.  Guess this is what I get for not being a java
> programmer :)

live and learn! :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/20043b6164b1
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/20043b6164b1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: