738331 - java.lang.OutOfMemoryError: at java.lang.String.<init>(String.java) at android.text.SpannableStringBuilder.toString(SpannableStringBuilder.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect, P3)

Description

[Chris Peterson [:cpeterson]]

This bug was filed from the Socorro interface and is 
report bp-af2cdc62-2143-403a-9152-c00962120321 .
============================================================= 

java.lang.OutOfMemoryError
at java.lang.String.<init>(String.java:513)
at java.lang.String.<init>(String.java:488)
at android.text.SpannableStringBuilder.toString(SpannableStringBuilder.java:943)
at org.mozilla.gecko.GeckoInputConnection.getExtractedText(GeckoInputConnection.java:242)
at com.android.internal.view.IInputConnectionWrapper.executeMessage(IInputConnectionWrapper.java:260)
at com.android.internal.view.IInputConnectionWrapper$MyHandler.handleMessage(IInputConnectionWrapper.java:75)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:130)
at android.app.ActivityThread.main(ActivityThread.java:3821)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:507)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:839)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Chris Peterson [:cpeterson]]

This OOM exception may be yet another instance of SpannableStringBuilder having stale selection indexes.

Interesting that all 3 crashes were on DROID3 phones.

Comment 2

[Scoobidiver (away)]

(In reply to Chris Peterson (:cpeterson) from comment #1)
> Interesting that all 3 crashes were on DROID3 phones.
It's the same user that crashed three times.

Comment 3

[Chris Peterson [:cpeterson]]

I believe this crash was fixed by bug 734156. content.toString() would try to allocate a huge string when the IME's bogus selection indexes were not clamped.

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: remove-catch-IndexOutOfBoundsException.patch

Remove IndexOutOfBoundsException band-aid now that we clamp bogus selection indexes.

I believe this crash has been fixed, so I would like to remove this old try/catch cruft to make sure we're not hiding another problem. We don't want this patch for Fennec 14 or 15.

Comment 5

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/55b91a3a460f

Comment 6

[Scoobidiver (away)]

There are two recent crashes with this signature (bp-1136174b-9537-41ec-a56f-214652120610, bp-2091f0e5-5ff5-4f69-8e91-78c0f2120613) but none with the stack in comment 0.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/55b91a3a460f