738337 - Branch mysql code for 201 returns to support ON DUPLICATE KEY UPDATE

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Toby Elliott [:telliott]]

In Bug 736132, the flow to make sure a 201 is returned when data is actually added to the system (as opposed to updated) is inefficient. It makes a call to determine whether the item exists, then another to either insert and replace.

This is because SQLAlchemy is working at the lowest common denominator here, and this is necessary for SQLite. However, mysql supports the INSERT..ON DUPLICATE KEY UPDATE syntax, and as a future improvement, we should look into doing this. 

Low priority, since the number of PUTs to the system is minimal, but if this changes in the future, we might want the extra speed.

Comment 1

[Ryan Kelly [:rfkelly]]

syncserver for 1.5 no longer does this, closing it out.

Comment 2

[James Bonacci [:jbonacci]]

ok