Branch mysql code for 201 returns to support ON DUPLICATE KEY UPDATE

VERIFIED FIXED

Status

VERIFIED FIXED
7 years ago
5 years ago

People

(Reporter: telliott, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-][sync-scale])

(Reporter)

Description

7 years ago
In Bug 736132, the flow to make sure a 201 is returned when data is actually added to the system (as opposed to updated) is inefficient. It makes a call to determine whether the item exists, then another to either insert and replace.

This is because SQLAlchemy is working at the lowest common denominator here, and this is necessary for SQLite. However, mysql supports the INSERT..ON DUPLICATE KEY UPDATE syntax, and as a future improvement, we should look into doing this. 

Low priority, since the number of PUTs to the system is minimal, but if this changes in the future, we might want the extra speed.
Whiteboard: [qa-]
(Reporter)

Updated

7 years ago
Whiteboard: [qa-] → [qa-][sync-scale]
syncserver for 1.5 no longer does this, closing it out.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
ok
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.