738338 - Regression: Talos extensions no longer work

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

Talos no longer works with addons.  Two issues:

1. Extensions get set twice because of our brain-dead parser.  Because
we do in typical fashion:

if self.extensions and ('extensions: []' in line):

This matches the documentation line

# Extensions to install in test (use "extensions: []" for none)

(This doesn't actually cause a problem ATM, it is just stupid and bad
behaviour)

2. I regressed zip_extractall with making the indentation consistent
with the horrible 2-space indentation in
http://hg.mozilla.org/build/talos/diff/099171bc6da5/talos/utils.py
. This causes the addon to not be extracted correctly if it is an .xpi.

Comment 1

[Jeff Hammel]

Attachment: fix

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 608378 [details] [diff] [review]
fix

Review of attachment 608378 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

::: talos/ffsetup.py
@@ +158,5 @@
>              tmpdir = tempfile.mkdtemp(suffix = "." + os.path.split(addon)[-1])
>              zip_extractall(zipfile.ZipFile(addon), tmpdir)
>              addonSrcPath = tmpdir
>  
> +        doc = minidom.parse(os.path.join(addonSrcPath, 'install.rdf'))

what changed here?

Comment 3

[Jeff Hammel]

(In reply to Joel Maher (:jmaher) from comment #2)

> > +        doc = minidom.parse(os.path.join(addonSrcPath, 'install.rdf'))
> 
> what changed here?

removal of trailing whitespace. (just happened to be debugging in this file)

Comment 4

[Jeff Hammel]

tested locally with android + ts and tsvg; pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=af3f63856d7f

Comment 5

[Jeff Hammel]

looks pretty green; pushing

Comment 6

[Jeff Hammel]

pushed: http://hg.mozilla.org/build/talos/rev/ee5c0b090d80

Comment 7

[Mozilla RelEng Bot]

Try run for af3f63856d7f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=af3f63856d7f
Results (out of 75 total builds):
    success: 73
    failure: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-af3f63856d7f

Comment 8

[Jeff Hammel]

The only failures are on android which we're not testing anyway