738361 - Music always fades out when your character is standing in a doorway

Status: VERIFIED FIXED

(Websites Graveyard :: BrowserQuest, defect)

Description

[Franck Lecollinet]

Steps:
- Go through a door, then don't move
- Current music always fades out when your character is standing in the doorway
- You need to move one step forward to hear the music of the area you just entered

Expected:
- If the area you left and the one you entered have different music (for instance, from the East of the village into the rat cave), both music should cross-fade even if you don't move.
- If both areas have the same music (ex. from the beach into the beach cave), no music fading should happen.
- If the area you entered has music but the previous had none (ie. from village houses out to the village), music should start to play the moment you go through the door.
- If the area you entered has no music (ie. village houses), music should fade out. Note: this is the only thing which currently has the correct behavior.

Comment 1

[Franck Lecollinet]

Fixed in this commit: https://github.com/mozilla/BrowserQuest/commit/4c23f09218ed745650c006dd182c1eae9a354206

Note: the 'Expected' summary above has changed since the initial bug report. There should be only a fade out of the village music in the first example, because we have removed music from the village rat cave.

Here is the updated expected behavior:
- If the area you left and the one you entered have different music (for instance, from the forest into maze cave), current music should fade out and the new music should start playing immediatly.
- If both areas have the same music (ex. from the beach into the beach cave), no music fading should happen.
- If the area you entered has music but the previous had none (ie. from village houses out to the village), music should start to play the moment you go through the door.
- If the area you entered has no music (ie. village houses, village rat cave), music should fade out.