The default bug view has changed. See this FAQ.

Avoid undefined properties JS warnings caused by imIncomingServer.js

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Instant Messaging
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 14.0

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 608403 [details] [diff] [review]
Patch

The attached patch cleans up various warnings caused by imIncomingServer.js not implementing some properties that end up actually read.

Example of warning this fixes:
Warning: reference to undefined property mgr.accounts
Source File: chrome://messenger/content/mail3PaneWindowCommands.js
Line: 412

The warnings displayed in the console were all incorrect because of bug 383524 so this wasn't as easy to figure out as it could have been...
Attachment #608403 - Flags: review?(dbienvenu)

Comment 1

5 years ago
Comment on attachment 608403 [details] [diff] [review]
Patch

however, since you're cleaning up errors, I see several of these different errors on every startup,:

Timestamp: 3/22/2012 3:32:27 PM
Error: Attempting to set a null username to an imIncomingServer
Source File: file:///C:/builds/tbirdhq/objdir-tb/mozilla/dist/bin/components/imIncomingServer.js
Line: 183

Timestamp: 3/22/2012 3:32:41 PM
Error: account is null
Source File: file:///C:/builds/tbirdhq/objdir-tb/mozilla/dist/bin/components/imContacts.js
Line: 1254
Attachment #608403 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 2

5 years ago
(In reply to David :Bienvenu from comment #1)

> Timestamp: 3/22/2012 3:32:27 PM
> Error: Attempting to set a null username to an imIncomingServer
> Source File:
> file:///C:/builds/tbirdhq/objdir-tb/mozilla/dist/bin/components/
> imIncomingServer.js
> Line: 183

You see it once per chat account. This is caused by bug 736434, you have already r+'ed the fix, but I haven't done the checkin yet.

> Timestamp: 3/22/2012 3:32:41 PM
> Error: account is null
> Source File:
> file:///C:/builds/tbirdhq/objdir-tb/mozilla/dist/bin/components/imContacts.js
> Line: 1254

I think this is because to work-around bug 736035 you hand removed the preferences of your chat accounts but haven't removed the blist.sqlite file from your profile at the same time. I think you see this error once per contact you had before hand removing your chat accounts.
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/comm-central/rev/60f3a527c8b0
Assignee: nobody → florian
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
(Assignee)

Comment 4

5 years ago
Comment on attachment 608403 [details] [diff] [review]
Patch

[Approval Request Comment]
This isn't strictly required for aurora as it's only cleaning up some error console noise, but I think not cluttering the error console with pointless messages helps gathering actionable feedback, so I would like us to take this fix on aurora.
Attachment #608403 - Flags: approval-comm-aurora?

Updated

5 years ago
Attachment #608403 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/releases/comm-aurora/rev/ff0b90dbcd98
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.