73842 - crash in nsProfile::MigrateAllProfiles (Can't migrate profile)

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Profile: Migration, defect)

Description

[John Morrison]

For another (trivial) bug, I nuked all the contents of (win2k)
 C:\Documents and Settings\Administrator\Application Data\Mozilla
so that I could force the dialog "Convert Profiles/Manage Profiles..." to come
up. (The other bug was that it had the wrong labels). 

However, now when I accept the offer to convert my 4x profile, I immediately
crash here in either a release build, or my own opt tree (pulled 11pm Monday).

// Migrates all unmigrated profiles
NS_IMETHODIMP nsProfile::MigrateAllProfiles()
{
    nsresult rv = NS_OK;
    for (PRInt32 i=0; i < gProfileDataAccess->mNumOldProfiles; i++)
    {
        ProfileStruct* profileItem = (ProfileStruct *)                          
                               (gProfileDataAccess->m4xProfiles->ElementAt(i));
        rv = MigrateProfile(profileItem->profileName.GetUnicode(), 
                           PR_FALSE /* don't show progress as modal window */);
        if (NS_FAILED(rv)) return rv;
    }

    return rv;
}

|profileItem| is null in the above loop on the first iteration (i==0)

Comment 1

[John Morrison]

Let me know if you want to look at this on my system. I hope I didn't break 
any "rules" in deleting that folder (but I've done it safely in the past). 

Comment 2

[Grace Bush]

John,

You should be able to safely remove that folder - I do most every day.  
I have heard of other cases of corrupted 4.x profiles causing crashes so you may 
try to choose [manage profiles], create a new one and see if you crash. 
I tried on both moz and commercial for today but cannot reproduce...

Comment 3

[John Morrison]

Grace. Thanks. (Yeah, I thought this was OK to do, but thought I'd mention it).
I can create a new profile and run fine. 

The thing with the code above is that while mozilla thinks I have profiles
to migrate, it doesn't find any on its list (hand-waving, not knowing this
code). That's puzzling.

(On a side note, if I select my unmigrated profile from the profile manager,
when it attempts to migrate it, I wind up crashing in another way, but that 
other way is completely a Style System crash. I'm sorting out that bug report
now). 

Comment 4

[John Morrison]

This is nuts. After reproducing this 5 times in two different builds, now, 
without me making any change that I know of, it works correctly everytime.

(The other thing still crashes, but that's a Style System thing.). 

I guess this is WFM, but I'll let bhuvan do that, and perhaps puzzle 
through how |profileItem| could have been null.

Comment 5

[Grace Bush]

I was puzzled by that code, 'migrate all profiles'....afaik that is not a 
feature!  Glad you are ok now

Comment 6

[racham]

Automigrate (where is there is only one 4x profile) uses MigrateAllProfiles 
routine. Infact we should change the title to something like 
MigrateSingleProfile and just migrate that one.

Adding Conrad (profilemanager boss) to the list.

I couldn't reproduce this either. Marking this WFM.

Comment 7

[John Morrison]

Reopening. Possibly a race condition. Sometimes you it, sometimes not.
I just now deleted my profiles folder, started and crashed on the migration. 
Then I immediately repeated the above, but this time, migration was fine.

Comment 8

[scottputterman]

Marking nsbeta1- because this won't affect users who use the UI to remove
profiles and create new ones and because it sounds like this doesn't happen all
of the time.

Comment 9

[Conrad Carlen (not reading bugmail)]

This is realted to (if not the same thing as) bug 68827. There is something
wrong with MigrateAllProfiles. The problem it has only arises in odd
circumstances. But see 68827 for why and even a patch.

Comment 10

[John Morrison]

Oh, good to hear that. I was just about to comment that this is the state 
that new users will be in (e.g., Nav4.x users upgrading to Netscape 6x). 
[In other words, it's not a contrived scenario to have a 4.x profile and
no 'Mozilla' folder with a 6.x profile in place].

Comment 11

[Conrad Carlen (not reading bugmail)]

Yeah - you have to have one and only one 4.x profile (not uncommon), and no
mozilla profiles (always to a new user). The thing that makes it an edge case
IMO, is you have to click "Exit" on the first and only the first time you run
mozilla under these circumstances.

Comment 12

[John Morrison]

Except that I was crashing without ever having hit exit. I would crash as soon 
as I hit the button to do the conversion. (Mind you, this was in a mozilla 
build where you are given the option; Netscape never presents the option 
(unless you twiddle with the default\pref\all-ns.js).

However, I tried this 7 or 8 times just now (both with the pref set to 
confirm, and to not confirm (ns default)), and I couldn't hit this crash
again. So, still and edge case, I guess ... :-]

Comment 13

[kevin arnold]

I am able to consistantly get this bug on NT 4.0 with the latest nightly builds 
(just tried 5/22/2001).

I've filed a Talkback report on it -> TB30767879X

I also have a Dependency Walker save of this crash if you would like that.

Comment 14

[kevin arnold]

Attachment: depends.exe save of crash

Comment 15

[Jussi-Pekka Mantere]

Removing nsenterprise nomination.

Comment 16

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 17

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 18

[Jesse Ruderman on Windows]

nsProfile::MigrateAllProfiles and mNumOldProfiles no longer exist in the codebase.  Since this bug never had steps to reproduce, I can only guess that this bug is long-gone.