738529 - Check "screen" wake lock in power manager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

Make the wake lock api useful by enabling the basic check of "screen" topic.

ref: https://github.com/andreasgal/gaia/issues/878

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: check "screen" wake lock in before turn off screen.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 608598 [details] [diff] [review]
check "screen" wake lock in before turn off screen.


>+  let wakeLockHandler = function wakeLockHandler(topic, state) {
>+    if (topic == "screen" && state != "locked-foreground") {
>+      if (Services.idle.idleTime > idleTimeout*1000) {
>+        screen.mozEnabled = false;
>+      }

Conversely, if the screen is off and a wake-lock is acquire, I think
android turns the screen back on.  That seems reasonable to me.  Let's
do that here.

r=me with that change

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #2)
> Comment on attachment 608598 [details] [diff] [review]
> check "screen" wake lock in before turn off screen.
> 
> 
> >+  let wakeLockHandler = function wakeLockHandler(topic, state) {
> >+    if (topic == "screen" && state != "locked-foreground") {
> >+      if (Services.idle.idleTime > idleTimeout*1000) {
> >+        screen.mozEnabled = false;
> >+      }
> 
> Conversely, if the screen is off and a wake-lock is acquire, I think
> android turns the screen back on.  That seems reasonable to me.  Let's
> do that here.

OK. But the code you quoted runs when the wake-lock is "released". I will add another clause for the opposite case.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Yep.  That's what I meant.

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Check "screen" wake lock before turn off screen. v2

Turn screen on if the wake lock is acquired.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/95e583913662

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/95e583913662