73856 - 4.x plugins cannot be scriptable

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[av (gone)]

4.x plugins miss a big piece of functionality since Mozilla no longer supports 
LiveConnect. To use a new way of making plugins scriptable, plugins should 
totally rewritten to use the new xpcom plugin API. This a fair amount of work 
and not all plugin vendors are probably immediately ready to invest resources 
into this task.

We need to make possible for them just to modify their existing plugins slightly 
so they become scriptable again.

Comment 1

[Peter Lubczynski]

*** Bug 62704 has been marked as a duplicate of this bug. ***

Comment 2

[av (gone)]

Attachment: changes in mozilla/include: npapi.h

Comment 3

[av (gone)]

Attachment: changes in mozilla/modules/plugin/public: nsplugindefs.h makefile.win makefile.in Manifest

Comment 4

[av (gone)]

Attachment: New in mozilla/modules/plugin/public: nsPIPluginHost.h

Comment 5

[av (gone)]

Attachment: changes in mozilla/modules/plugin/nglsrc: ns4xPluginInstance.cpp ns4xPluginInstance.h ns4xPlugin.cpp nsPluginHostImpl.h nsPluginHostImpl.cpp

Comment 6

[av (gone)]

Attachment: changes in mozilla/content/html/content/src: nsGenericHTMLElement.cpp

Comment 7

[av (gone)]

Vidur, please have a look and review (super). Johnny, I guess we will need your 
approval on changes to nsGenericHTMLElement.cpp.

Comment 8

[Johnny Stenback (:jst)]

av, per our discussion earlier today you have my approval for cheking in this
change to nsGenericHTMLElement.cpp.

Comment 9

[vidur (gone)]

Required change:
 - In both ns4xPluginInstance::GetScriptablePeer and
ns4xPluginInstance::GetScriptableInstance, the return value should be primed
with null before we call the old-style plugin.

Recommended changes:
 - In ns4xPluginInstance::GetValue, I'd prefer to see the break statements left
in and all returns happening from the same point.
 - It would be good to get all the NPP and NPN variables rationalized. The fact
that there's overlap between the original set and the new set (specifically
nsPluginInstanceVariable_DoCacheBool) is very disconcerting. Also, the different
enums in nsplugindefs.h aren't split out correctly.

With the required change fixed, sr=vidur.

Comment 10

[av (gone)]

Patch with vidur's corrections is in. Marking fixed.

Comment 11

[shrirang khanzode]

verified patch is in version 1.244 on lxr.marking VERIF