738711 - The rootMsgFolder getter of imIncomingServer is sometimes called

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch

I saw this while running mozmill tests with an IRC account in the default profile. It's called with this stack:

0 anonymous() ["file:///Users/florian/buildhg/comm-central/obj-tbird/mozilla/dist/DailyDebug.app/Contents/MacOS/components/imIncomingServer.js":218]
    this = [object Object]
1 GetInboxFolder(server = [object Object]) ["chrome://messenger/content/mailWindowOverlay.js":1158]
    nsMsgFolderFlags = undefined
    rootMsgFolder = undefined
    this = [object ChromeWindow @ 0x3050780 (native @ 0x304ffb8)]
2 MigrateFolderViews() ["chrome://messenger/content/msgMail3PaneWindow.js":1256]
    index = 2
    inbox = [xpconnect wrapped nsIMsgFolder @ 0x30747a0 (native @ 0x1e479800)]
    server = [object Object]
    servers = [xpconnect wrapped nsISupportsArray @ 0x30746a0 (native @ 0x3074660)]
    folderViewsVersion = 0
    this = [object ChromeWindow @ 0x3050780 (native @ 0x304ffb8)]
3 LoadPostAccountWizard() ["chrome://messenger/content/msgMail3PaneWindow.js":449]
    toolbarset = undefined
    toolbox = undefined
    completeStartup = [function]
    startMsgHdr = undefined
    startFolderURI = undefined
    this = [object ChromeWindow @ 0x3050780 (native @ 0x304ffb8)]
4 OnLoadMessenger() ["chrome://messenger/content/msgMail3PaneWindow.js":413]
    panelcontainer = undefined
    tabmail = [object XULElement @ 0x21ee7aa0 (native @ 0x1e07bff0)]
    this = [object ChromeWindow @ 0x3050780 (native @ 0x304ffb8)]
5 onload(event = [object Event @ 0x1d757cb0 (native @ 0x1e0c8230)]) ["chrome://messenger/content/messenger.xul":1]
    this = [object ChromeWindow @ 0x3050780 (native @ 0x304ffb8)]


Not implementing it seems harmless as GetInboxFolder has a try/catch and will return null when an exception is thrown, the only visible effect is "TypeError: rootMsgFolder is null" printed in the log as GetInboxFolder dumps the exception.

I don't like noise and some future caller may not be as careful as GetInboxFolder so I think we should still fix it.

Comment 1

[Florian Quèze [:florian]]

http://hg.mozilla.org/comm-central/rev/b13bd51e8aad