Run mozmill tests with an IM account in the default profile

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 18.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 608784 [details] [diff] [review]
Patch

(In reply to David :Bienvenu from bug 736486 comment #3)
> I wonder if it would possible to tweak the mozmill tests to define an im
> account in the default profile and see if any of the tests break in
> interesting ways.

I've tried this, here are the results:

- The only test that is consistently broken is mail/test/mozmill/account/test-archive-options.js because it hardcodes the index of accounts in the Account Settings dialog.

- The other failures I saw seem random (although I wouldn't guarantee it, I'm not expert yet at the art of reading these obfuscated test result logs).

- I also noticed some noise in the log that can (and I think should) be fixed (bug 738711).

I'm attaching the changes I made to try this, so that others can try too.

I don't know if we want to integrate this patch, so requesting feedback instead of review.
Attachment #608784 - Flags: feedback?(dbienvenu)

Updated

6 years ago
Attachment #608784 - Flags: feedback?(dbienvenu) → feedback+
Comment on attachment 608784 [details] [diff] [review]
Patch

I'm wondering if this is something we will want to push to comm-central or if it's too hackish. I've just asked on IRC, David thinks we should do it but would like to have your opinion too.

I definitely wouldn't land this before looking at try server build results to see if it creates perma-oranges that weren't visible on my machine.
Attachment #608784 - Flags: feedback?(mbanner)
Comment on attachment 608784 [details] [diff] [review]
Patch

I don't think this is too hackish as its based on what we've done before - it would be nice to have tests for chat account creation though when we get that far.
Attachment #608784 - Flags: feedback?(mbanner) → feedback+
florian ?
Created attachment 661196 [details] [diff] [review]
Patch v2

Now that Thunderbird ships with IM on by default, I think we should move forward here.
I agree that "it would be nice to have tests for chat account creation" (comment 1) but I think we can do it in a separate bug.

I pushed attachment 608784 [details] [diff] [review] to try and it failed consistently (https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=118d7e1ebfb8).

The error log is:
SUMMARY-UNEXPECTED-FAIL | test-newmailaccount.js | test-newmailaccount.js::test_get_an_account
  EXCEPTION: account.defaultIdentity is null
    at: test-newmailaccount-helpers.js line 166
       remove_email_account test-newmailaccount-helpers.js 166
       test_get_an_account test-newmailaccount.js 167
       Runner.prototype.wrapper frame.js 582
       Runner.prototype._runTestModule frame.js 652
       Runner.prototype.runTestModule frame.js 698
       Runner.prototype.runTestDirectory frame.js 522
       runTestDirectory frame.js 704
       Bridge.prototype._execFunction server.js 179
       Bridge.prototype.execFunction server.js 183
SUMMARY-UNEXPECTED-FAIL | test-newmailaccount.js | test-newmailaccount.js::test_restored_ap_tab_works
  EXCEPTION: account.defaultIdentity is null
    at: test-newmailaccount-helpers.js line 166
       remove_email_account test-newmailaccount-helpers.js 166
       test_get_an_account test-newmailaccount.js 167
       test_restored_ap_tab_works test-newmailaccount.js 227
       Runner.prototype.wrapper frame.js 582
       Runner.prototype._runTestModule frame.js 652
       Runner.prototype.runTestModule frame.js 698
       Runner.prototype.runTestDirectory frame.js 522
       runTestDirectory frame.js 704
       Bridge.prototype._execFunction server.js 179
       Bridge.prototype.execFunction server.js 183


This new attachment fixes this. I pushed it to try, and things look OK (https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=869169ae802c).
Assignee: nobody → florian
Attachment #608784 - Attachment is obsolete: true
Attachment #661196 - Flags: review?(mbanner)
Comment on attachment 661196 [details] [diff] [review]
Patch v2

Review of attachment 661196 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by - this mostly looks good to me.

::: mail/test/mozmill/account/test-archive-options.js
@@ +43,5 @@
>    // XXX: This is pretty brittle, and assumes 1) that there are 8 items in each
>    // account's tree, and 2) that the order of the accounts is as we expect.
> +  // The + 1 when index != 0 is for the line used by the IRC account,
> +  // which is at the second position.
> +  click_account_tree_row(amc, index*8 + 2 + (index ? 1 : 0));

Spaces on either side of the *
Comment on attachment 661196 [details] [diff] [review]
Patch v2

Mike has already looked today and can r+ this, so redirecting the review to him.
Attachment #661196 - Flags: review?(mbanner) → review?(mconley)
Comment on attachment 661196 [details] [diff] [review]
Patch v2

Review of attachment 661196 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, this looks good (and thanks for the try build). With the nit I found fixed, r=me.

Thanks!
Attachment #661196 - Flags: review?(mconley) → review+
https://hg.mozilla.org/comm-central/rev/8bbb9f722e7b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Summary: Investigate running mozmill tests with an IM account in the default profile → Run mozmill tests with an IM account in the default profile
You need to log in before you can comment on or make changes to this bug.