738730 - Resizing browser on the desktop before starting the game does strange things to the canvas

Status: VERIFIED FIXED

(Websites Graveyard :: BrowserQuest, defect)

Description

[Marlena Compton [:marlenac]]

I was able to reproduce this on FF11 and Chrome.  The steps to reproduce are similar for both but the outcome is slightly different in each browser (guessing webkit vs. non-webkit.)

Steps to reproduce:
1. Open browser (Chrome or FF11)
2. Drag browser so that it's large
3. Drag browser so it's smaller
4. Navigate to browserquest ip
5. On both browsers, you will see the message for rotating device to landscape even though you are on desktop
6. Drag the browser so the window is large and this goes away
7. Start browser quest

On FF11:  Canvas is 0.25 the size of the canvas border
On Chrome: div#bar-container renders over the canvas foreground

Screenshot:
https://skitch.com/e-marlenac/8cay6/resize

Comment 1

[Guillaume Lecollinet]

There are two different problems here:

1. The message saying you should rotate to landscape appears. This is a normal behavior of most browsers, which trigger "portrait mode" whenever the window is narrowed down to a column. I don't think I can do much about this.


2. BrowserQuest starts at the incorrect scale if you resize the window between initial page load and game start. This is completely BQ-related and will be fixed.

Comment 2

[Guillaume Lecollinet]

Fixed in this commit: https://github.com/mozilla/BrowserQuest/commit/d51a4cb53aa91faa47ad7aae4f96f45fc5bb8d28