On Android the enter key (KEYCODE_ENTER) is distinct from the dpad center key (KEYCODE_DPAD_ENTER). But the widget layer translates both of them into DOM_VK_RETURN. I think the best mapping for the dpad center key is DOM_VK_ENTER, but I am uncertain of all the consequences of such a change. fyi, android does not have a keycode for the numpad enter key, so this does not introduce new ambiguities.
Attachment #608805 - Flags: review?(mbrubeck) → review+
Try run for 9b539a2f38de is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=9b539a2f38de Results (out of 42 total builds): success: 38 warnings: 3 failure: 1 Builds (or logs if builds failed) available at: http://email@example.com
Must have been something intermittent, this build shows it is all good. https://tbpl.mozilla.org/?tree=Try&rev=ffcd92b825f8 Anyway, I'll land this in a couple of days, I am taking off in a second and don't want to be responsible for messing up the entire world while I am gone :)
Assignee: nobody → eitan
Target Milestone: --- → mozilla14
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.