The default bug view has changed. See this FAQ.

No way to distinguish between KEYCODE_DPAD_CENTER and KEYCODE_ENTER

RESOLVED FIXED in Firefox 13

Status

()

Core
Widget: Android
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Trunk
mozilla14
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox13 fixed, firefox14 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
On Android the enter key (KEYCODE_ENTER) is distinct from the dpad center key (KEYCODE_DPAD_ENTER). But the widget layer translates both of them into DOM_VK_RETURN.

I think the best mapping for the dpad center key is DOM_VK_ENTER, but I am uncertain of all the consequences of such a change.

fyi, android does not have a keycode for the numpad enter key, so this does not introduce new ambiguities.
(Assignee)

Comment 1

5 years ago
Created attachment 608805 [details] [diff] [review]
Re-map Android's KEYCODE_DPAD_CENTER to DOM_VK_ENTER.
Attachment #608805 - Flags: review?(mbrubeck)
Attachment #608805 - Flags: review?(mbrubeck) → review+

Comment 2

5 years ago
Try run for 9b539a2f38de is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=9b539a2f38de
Results (out of 42 total builds):
    success: 38
    warnings: 3
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eisaacson@mozilla.com-9b539a2f38de
(Assignee)

Comment 3

5 years ago
Must have been something intermittent, this build shows it is all good.
https://tbpl.mozilla.org/?tree=Try&rev=ffcd92b825f8

Anyway, I'll land this in a couple of days, I am taking off in a second and don't want to be responsible for messing up the entire world while I am gone :)
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/dea46b8a52ad
Assignee: nobody → eitan
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/dea46b8a52ad
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-aurora/rev/328ae1116d50
status-firefox13: --- → fixed
status-firefox14: --- → fixed
You need to log in before you can comment on or make changes to this bug.