738792 - fix strict Javascript warnings in Thunderbird addressbook (found in Error console)

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[:aceman]

Timestamp: 23.03.2012 22:07:04
Warning: octal literals and octal escape sequences are deprecated
Source File: chrome://messenger/content/addressbook/abTrees.js
Line: 158, Column: 46
Source Code:
      foStream.init(file, 0x02 | 0x08 | 0x20, 0666, 0); 

Timestamp: 23.03.2012 22:07:04
Warning: function getDirectoryValue does not always return a value
Source File: chrome://messenger/content/addressbook/abTrees.js
Line: 207

Timestamp: 23.03.2012 22:07:04
Warning: octal literals and octal escape sequences are deprecated
Source File: chrome://messenger/content/addressbook/abCommon.js
Line: 875, Column: 62
Source Code:
    file.create(Components.interfaces.nsIFile.DIRECTORY_TYPE, 0777);

Comment 1

[:aceman]

Mconley, what can be used instead of the octal values?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

aceman:

Hm... maybe something like this?  https://bugzilla.mozilla.org/attachment.cgi?id=452323&action=diff

I'm surprised there's not a more graceful solution...that looks kind of like a hack.

-Mike

Comment 3

[:aceman]

Thanks.
Do you want the parseInt() inline or can I create some descriptive constants for the 2 values?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

I'm a fan of declaring constants - I'd recommend going that route.

Comment 5

[:aceman]

Are those permission actually correct?
Do we want the file world-writable and dirs world-accessible? Or is that some kind of mask, not the final permissions?

Comment 6

[Mike Conley (:mconley) (:⚙️)]

CC'ing Standard8, who might know more about how we should be setting file permissions...

Comment 7

[:aceman]

Timestamp: 26.03.2012 23:23:31
Warning: assignment to undeclared variable j
Source File: chrome://messenger/content/addressbook/abDragDrop.js
Line: 291

Comment 8

[:aceman]

(In reply to :aceman from comment #5)
> Are those permission actually correct?
> Do we want the file world-writable and dirs world-accessible? Or is that
> some kind of mask, not the final permissions?
(In reply to Mike Conley (:mconley) from comment #6)
> CC'ing Standard8, who might know more about how we should be setting file
> permissions...

Standard8, any ideas here?

Comment 9

[:aceman]

Attachment: patch

So let's start with something.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 635080 [details] [diff] [review]
patch

Review of attachment 635080 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks aceman!

Comment 11

[:aceman]

Do we need more reviews here?

Comment 12

[Mark Banner (:standard8)]

Nope, mconley is enough :-)

Comment 13

[:aceman]

Ok, thanks.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/2b7433987db1