The default bug view has changed. See this FAQ.

fix strict Javascript warnings in Thunderbird addressbook (found in Error console)

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
Address Book
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 16.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Timestamp: 23.03.2012 22:07:04
Warning: octal literals and octal escape sequences are deprecated
Source File: chrome://messenger/content/addressbook/abTrees.js
Line: 158, Column: 46
Source Code:
      foStream.init(file, 0x02 | 0x08 | 0x20, 0666, 0); 

Timestamp: 23.03.2012 22:07:04
Warning: function getDirectoryValue does not always return a value
Source File: chrome://messenger/content/addressbook/abTrees.js
Line: 207

Timestamp: 23.03.2012 22:07:04
Warning: octal literals and octal escape sequences are deprecated
Source File: chrome://messenger/content/addressbook/abCommon.js
Line: 875, Column: 62
Source Code:
    file.create(Components.interfaces.nsIFile.DIRECTORY_TYPE, 0777);
(Assignee)

Comment 1

5 years ago
Mconley, what can be used instead of the octal values?
aceman:

Hm... maybe something like this?  https://bugzilla.mozilla.org/attachment.cgi?id=452323&action=diff

I'm surprised there's not a more graceful solution...that looks kind of like a hack.

-Mike
(Assignee)

Comment 3

5 years ago
Thanks.
Do you want the parseInt() inline or can I create some descriptive constants for the 2 values?
I'm a fan of declaring constants - I'd recommend going that route.
(Assignee)

Comment 5

5 years ago
Are those permission actually correct?
Do we want the file world-writable and dirs world-accessible? Or is that some kind of mask, not the final permissions?
CC'ing Standard8, who might know more about how we should be setting file permissions...
(Assignee)

Comment 7

5 years ago
Timestamp: 26.03.2012 23:23:31
Warning: assignment to undeclared variable j
Source File: chrome://messenger/content/addressbook/abDragDrop.js
Line: 291
(Assignee)

Comment 8

5 years ago
(In reply to :aceman from comment #5)
> Are those permission actually correct?
> Do we want the file world-writable and dirs world-accessible? Or is that
> some kind of mask, not the final permissions?
(In reply to Mike Conley (:mconley) from comment #6)
> CC'ing Standard8, who might know more about how we should be setting file
> permissions...

Standard8, any ideas here?

Updated

5 years ago
OS: Linux → All
Hardware: x86 → All
(Assignee)

Comment 9

5 years ago
Created attachment 635080 [details] [diff] [review]
patch

So let's start with something.
Attachment #635080 - Flags: review?(mconley)
Attachment #635080 - Flags: feedback?(mbanner)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Comment on attachment 635080 [details] [diff] [review]
patch

Review of attachment 635080 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks aceman!
Attachment #635080 - Flags: review?(mconley) → review+
(Assignee)

Comment 11

5 years ago
Do we need more reviews here?
Nope, mconley is enough :-)
Attachment #635080 - Flags: feedback?(mbanner)
(Assignee)

Comment 13

5 years ago
Ok, thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2b7433987db1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in before you can comment on or make changes to this bug.