738894 - Omnibus ad-blocking bug for April 2012

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'm all out of ad puns :-(

Comment 1

[Chris Lawson (gone)]

On http://www.technewsworld.com/edpick/74694.html?wlc=1332793678

img src="servedby.flashtalking.com"

(That domain also spews a full-content-covering JS-based Flash ad; blocking scripts from flashtalking.com should prevent it.)

Comment 2

[Chris Lawson (gone)]

On http://blog.intercom.io/whats-in-a-name/

div id="SignupAd"

Comment 3

[Chris Lawson (gone)]

On http://www.wate.com/story/17309103/spirit-airlines-flight-makes-emergency-landing-at-mcghee-tyson

div[class*="wnMultiAd "]

Comment 4

[philippe (part-time)]

On metafilter.com
(e.g http://www.metafilter.com/114168/The-Iced-Coffee-Economy)

<div class="google-ad">
    <div class="google-label">
    ...
   </div>
   <div class="google-text">

--> div[class="google-ad"]

Comment 5

[Chris Lawson (gone)]

On http://www.survivetheapocalypse.net/2012/04/05/how-to-make-a-zombie/ , there are ads all down the right side of the page.

div[class*=" ad-codes"]

should do it.

Comment 6

[Chris Lawson (gone)]

On http://online.wsj.com/article/SB10001424052702303815404577335783535660546.html

at the very bottom of the article, between the comments section and the footer, there's an "Offers" section.

div[id^="wsjSelect"] oughta take care of it.

Comment 7

[Chris Lawson (gone)]

On http://www.murfreesboropost.com/boner-rejects-sexual-harassment-allegations-cms-30900

img[src*="/adman/"]

Comment 8

[philippe (part-time)]

http://mainichi.jp/english/english/
sidebar & bottom of articles (some on individual articles only)

div[class="SquareAd"],
div[class="AdRecommend"],
div[class="AdBrand"],
div[class="AdMrq"],
div[class="ArticleAd"][class="clr"] 

/* couldn't they tag them all with one class… ? :p */

Comment 9

[Chris Lawson (gone)]

On http://www.metro.co.uk/weird/897822-chinese-man-disgusts-crowds-by-pulling-1-6-ton-car-with-eye-sockets

it looks like all the stuff at the bottom is ads.

div[id="metro_extras"]

should do it.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Chris Lawson from comment #1)
> (That domain also spews a full-content-covering JS-based Flash ad; blocking
> scripts from flashtalking.com should prevent it.)

Yeah, they're also running Flash ads on imdb.com right now, e.g. http://cdn.flashtalking.com/xre/26/261909/317887/swf/GnR_Recipe_Spinner_Weekend_BASE_FIL_728x90.swf

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to Chris Lawson from comment #1)
> On http://www.technewsworld.com/edpick/74694.html?wlc=1332793678
> 
> img src="servedby.flashtalking.com"

(In reply to Chris Lawson from comment #2)
> On http://blog.intercom.io/whats-in-a-name/
> 
> div id="SignupAd"

I couldn't find the matching ads on those two pages.

(In reply to philippe from comment #8)
> div[class="ArticleAd"][class="clr"] 

This one doesn't seem to work for me unless I use ~= (or I suppose *=)

I used the ~= syntax for comment 5 as well.

(In reply to Chris Lawson from comment #9)
> On
> http://www.metro.co.uk/weird/897822-chinese-man-disgusts-crowds-by-pulling-1-
> 6-ton-car-with-eye-sockets
> 
> it looks like all the stuff at the bottom is ads.
> 
> div[id="metro_extras"]
> 
> should do it.

I don't like that rule at all (and I can't find any other reasonable ones), because 1) it's not ad-like at all, and 2) it seems likely to block real content in metro sections the world over.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: April 2012 Omnibus Ad-Blocking

Per comment 11.

Comment 13

[Stuart Morgan]

Comment on attachment 621256 [details] [diff] [review]
April 2012 Omnibus Ad-Blocking

Review of attachment 621256 [details] [diff] [review]:
-----------------------------------------------------------------

sr=smorgan

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/b90f93cdb2ae