738896 - tr_importxml was not working and needs some patching on BZ 4.2 / Testopia 2.4

Status: RESOLVED FIXED

(Testopia :: Import/Export, defect)

Comment 1

[Peter Florijn]

Attachment: Patch to make it work

Comment 2

[Frédéric Buclin]

Comment on attachment 608976 [details] [diff] [review]
Patch to make it work

>-    my $product = Bugzilla::Product::check_product( $e->field('tr:product') );
>+    my $product = new Bugzilla::Product( {name => $e->field('tr:product')} );

check_product() has been replaced by ->check(). new() doesn't throw any error if the product is invalid.

Comment 3

[rojanu]

Attachment: Test Case Import

Comment 4

[rojanu]

Attachment: Import errors

I have updated the patch with Product->check() but still errors occurred when importing an XML file exported from Testopia from 3.6

Comment 6

[Frédéric Buclin]

Comment on attachment 613197 [details] [diff] [review]
Test Case Import

>-    my $product = Bugzilla::Product::check_product( $e->parent->field('tr:product') );
>+    my $product = Bugzilla::Product->check($e->field('tr:product'));

The parameter is $e->parent->field('tr:product'), not $e->field('tr:product'). This can be fixed on checkin. Otherwise looks good. r=LpSolit

Comment 7

[Frédéric Buclin]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/extensions/testopia/trunk/
modified extensions/Testopia/lib/Importer.pm
Committed revision 651.