738962 - Make sure prefs.js isn't installed mode 755

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Guido Günther]

Attachment: 0001-Make-sure-prefs.js-isn-t-installed-executable.patch

By default prefs.js ends up mode 755, it should be 644 - attached patch fixes this.

Comment 1

[Guido Günther]

Attachment: Make sure prefs.js isn-t installed executable

Same patch but with patch header matching the mozilla patch guidelines.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 609429 [details] [diff] [review]
Make sure prefs.js isn-t installed executable

r=NPOTB

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 097fafd97fbc

Comment 4

[Robert Brand]

Attachment: patch_v2

This checkin broke building sunbird (win32) for me:

c:/build/cc-livingdead/sb-en/mozilla/config/nsinstall.exe -m644 /c/build/cc-livingdead/comm-central/calendar/sunbird/app/profile/prefs.js ../../../mozilla/dist/bin/defaults/profile
nsinstall: not enough arguments
make[5]: *** [libs] Error 3
make[5]: Leaving directory `/c/build/cc-livingdead/sb-en/calendar/sunbird/app'

Using "-m 644" instead of "-m644" works fine. So if that syntax is ok for unix, too, I'd appreciate a small fix.

Comment 5

[Guido Günther]

Yes. "-m 644" works on Unix too.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/1220a9fe506a