Closed
Bug 738962
Opened 12 years ago
Closed 12 years ago
Make sure prefs.js isn't installed mode 755
Categories
(Calendar :: Sunbird Only, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: agx, Assigned: agx)
Details
Attachments
(2 files, 1 obsolete file)
897 bytes,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
749 bytes,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
By default prefs.js ends up mode 755, it should be 644 - attached patch fixes this.
Attachment #609021 -
Flags: review?(mschroeder)
Assignee | ||
Comment 1•12 years ago
|
||
Same patch but with patch header matching the mozilla patch guidelines.
Attachment #609021 -
Attachment is obsolete: true
Attachment #609021 -
Flags: review?(mschroeder)
Attachment #609429 -
Flags: review?(mschroeder)
Assignee | ||
Updated•12 years ago
|
Summary: Make sure prefs.js isn't enstalled mode 755 → Make sure prefs.js isn't installed mode 755
Comment 2•12 years ago
|
||
Comment on attachment 609429 [details] [diff] [review] Make sure prefs.js isn-t installed executable r=NPOTB
Attachment #609429 -
Flags: review?(mschroeder) → review+
Comment 3•12 years ago
|
||
Pushed to comm-central changeset 097fafd97fbc
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
Comment 4•12 years ago
|
||
This checkin broke building sunbird (win32) for me: c:/build/cc-livingdead/sb-en/mozilla/config/nsinstall.exe -m644 /c/build/cc-livingdead/comm-central/calendar/sunbird/app/profile/prefs.js ../../../mozilla/dist/bin/defaults/profile nsinstall: not enough arguments make[5]: *** [libs] Error 3 make[5]: Leaving directory `/c/build/cc-livingdead/sb-en/calendar/sunbird/app' Using "-m 644" instead of "-m644" works fine. So if that syntax is ok for unix, too, I'd appreciate a small fix.
Assignee | ||
Comment 5•12 years ago
|
||
Yes. "-m 644" works on Unix too.
Updated•12 years ago
|
Attachment #619446 -
Flags: review?(philipp)
Updated•12 years ago
|
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: FIXED → ---
Updated•12 years ago
|
Attachment #619446 -
Flags: review?(philipp) → review+
Updated•12 years ago
|
Keywords: checkin-needed
Comment 6•12 years ago
|
||
http://hg.mozilla.org/comm-central/rev/1220a9fe506a
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Updated•12 years ago
|
Assignee: nobody → agx
You need to log in
before you can comment on or make changes to this bug.
Description
•