Closed
Bug 738975
Opened 12 years ago
Closed 12 years ago
Speed up building of layout/svg/base/src by dropping content/html/content/src from the include path
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: jwatt, Assigned: jwatt)
References
(Blocks 1 open bug)
Details
(Whiteboard: [include-what-you-use])
Attachments
(1 file)
|
1.84 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
One more step towards fixing bug 738969 is dropping content/html/content/src from the include path for layout/svg/base/src. The only reason we need it is because nsImageLoadingContent.h unnecessarily includes nsGenericHTMLElement.h. This patch drops nsGenericHTMLElement.h and other unnecessary headers from the include directives in nsImageLoadingContent.h and remove content/html/content/src from the include paths for layout/svg/base/src. This small change reduces the warm |make -B| build time for layout/svg/base/src by about 1.1% for me. bz: see bug 738969 comment 0 for background.
Attachment #609029 -
Flags: review?(bzbarsky)
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [include-what-you-use]
|
|
||
Comment 1•12 years ago
|
||
Comment on attachment 609029 [details] [diff] [review] patch r=me
Attachment #609029 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/df36e7f3aba4
Assignee: nobody → jwatt
Target Milestone: --- → mozilla14
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df36e7f3aba4
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•