TB-IM: Style the Chat window system friendlier

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Theme
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

Trunk
Thunderbird 14.0
All
Windows XP
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(5 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 609033 [details]
Screenshot of the actual state.

The actual styles are Win7 centric also under Windows XP or Classic mode. The backgrounds have a fixed light blue background, the splitters are 1px wide. Also the list items have a Win7 style.
(Assignee)

Comment 1

6 years ago
Created attachment 609034 [details] [diff] [review]
Patch

This patch uses system colors for WinXP and Classic mode of Win7. Also the splitters are like them of the Three pane window.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #609034 - Flags: ui-review?(nisses.mail)
Attachment #609034 - Flags: review?(nisses.mail)
(Assignee)

Comment 2

6 years ago
Oops, forgot to say this patch needs Bug 734736 applied first.
(Assignee)

Comment 3

6 years ago
Created attachment 609036 [details]
Screenshot with patch applied under XP

Use the system colors except in Chat content (this should be a other bug because this isn't easy to do).

Comment 4

6 years ago
(In reply to Richard Marti [:paenglab] from comment #3)
> Created attachment 609036 [details]
> Screenshot with patch applied under XP
> 
> Use the system colors except in Chat content (this should be a other bug
> because this isn't easy to do).

Look out for the overlap on the splitters near the bottom-right. That is, the part that looks like this: --|
(Assignee)

Comment 5

6 years ago
Created attachment 609090 [details] [diff] [review]
Patch v2

Good catch, Jim. Better approach for the splitters.
Attachment #609034 - Attachment is obsolete: true
Attachment #609034 - Flags: ui-review?(nisses.mail)
Attachment #609034 - Flags: review?(nisses.mail)
Attachment #609090 - Flags: ui-review?(nisses.mail)
Attachment #609090 - Flags: review?(nisses.mail)
Seems to have bitrotted
I can't apply the patch either, but I don't think it can have bitrotted as http://hg.mozilla.org/comm-central/filelog/tip/mail/themes/qute/mail/chat.css only has the initial revision.

Richard may have had other patches applied before this one though.
(Assignee)

Comment 8

6 years ago
Have you applied first Bug 734736 as noted in comment 2?
Comment on attachment 609090 [details] [diff] [review]
Patch v2

Looks good once a chat is started, but doesn't look quite right if you're looking at previous conversations. For some reason it drops half the sizer.
Attachment #609090 - Flags: ui-review?(nisses.mail) → ui-review-
Created attachment 609370 [details]
issue in action
(Assignee)

Comment 11

6 years ago
Created attachment 609452 [details] [diff] [review]
Patch v3

Fixed border problem.
Attachment #609090 - Attachment is obsolete: true
Attachment #609090 - Flags: review?(nisses.mail)
Attachment #609452 - Flags: ui-review?(nisses.mail)
Attachment #609452 - Flags: review?(nisses.mail)
Comment on attachment 609452 [details] [diff] [review]
Patch v3

Looks good and works well with both regular and High Contrast themes in XP (tested in compability mode).
Attachment #609452 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 609452 [details] [diff] [review]
Patch v3

And css looks good too.
Attachment #609452 - Flags: review?(nisses.mail) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/671d3b476a03
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
(Assignee)

Comment 15

6 years ago
Comment on attachment 609452 [details] [diff] [review]
Patch v3

Should this go to Aurora to be consistent over all versions? If yes, I'm doing a special patch because a other related patch (Bug 734736) isn't for aurora.
Attachment #609452 - Flags: approval-comm-aurora?
Attachment #609452 - Flags: approval-comm-aurora? → approval-comm-aurora+
(Assignee)

Comment 16

5 years ago
Created attachment 611567 [details] [diff] [review]
Patch for comm-aurora

Patch adapted to comm-aurora
Comment on attachment 611567 [details] [diff] [review]
Patch for comm-aurora

[Triage Comment]
Switch flags to the patch that will land on aurora.
Attachment #611567 - Flags: approval-comm-aurora+
Attachment #609452 - Flags: approval-comm-aurora+
http://hg.mozilla.org/releases/comm-aurora/rev/4665697c1864
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.