Closed Bug 738982 Opened 9 years ago Closed 9 years ago

TB-IM: Style the Chat window system friendlier

Categories

(Thunderbird :: Theme, defect)

All
Windows XP
defect
Not set
normal

Tracking

(thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 14.0
Tracking Status
thunderbird13 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(5 files, 2 obsolete files)

The actual styles are Win7 centric also under Windows XP or Classic mode. The backgrounds have a fixed light blue background, the splitters are 1px wide. Also the list items have a Win7 style.
Attached patch Patch (obsolete) — Splinter Review
This patch uses system colors for WinXP and Classic mode of Win7. Also the splitters are like them of the Three pane window.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #609034 - Flags: ui-review?(nisses.mail)
Attachment #609034 - Flags: review?(nisses.mail)
Oops, forgot to say this patch needs Bug 734736 applied first.
Use the system colors except in Chat content (this should be a other bug because this isn't easy to do).
(In reply to Richard Marti [:paenglab] from comment #3)
> Created attachment 609036 [details]
> Screenshot with patch applied under XP
> 
> Use the system colors except in Chat content (this should be a other bug
> because this isn't easy to do).

Look out for the overlap on the splitters near the bottom-right. That is, the part that looks like this: --|
Attached patch Patch v2 (obsolete) — Splinter Review
Good catch, Jim. Better approach for the splitters.
Attachment #609034 - Attachment is obsolete: true
Attachment #609034 - Flags: ui-review?(nisses.mail)
Attachment #609034 - Flags: review?(nisses.mail)
Attachment #609090 - Flags: ui-review?(nisses.mail)
Attachment #609090 - Flags: review?(nisses.mail)
Seems to have bitrotted
I can't apply the patch either, but I don't think it can have bitrotted as http://hg.mozilla.org/comm-central/filelog/tip/mail/themes/qute/mail/chat.css only has the initial revision.

Richard may have had other patches applied before this one though.
Have you applied first Bug 734736 as noted in comment 2?
Comment on attachment 609090 [details] [diff] [review]
Patch v2

Looks good once a chat is started, but doesn't look quite right if you're looking at previous conversations. For some reason it drops half the sizer.
Attachment #609090 - Flags: ui-review?(nisses.mail) → ui-review-
Attached patch Patch v3Splinter Review
Fixed border problem.
Attachment #609090 - Attachment is obsolete: true
Attachment #609090 - Flags: review?(nisses.mail)
Attachment #609452 - Flags: ui-review?(nisses.mail)
Attachment #609452 - Flags: review?(nisses.mail)
Comment on attachment 609452 [details] [diff] [review]
Patch v3

Looks good and works well with both regular and High Contrast themes in XP (tested in compability mode).
Attachment #609452 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 609452 [details] [diff] [review]
Patch v3

And css looks good too.
Attachment #609452 - Flags: review?(nisses.mail) → review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/671d3b476a03
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 609452 [details] [diff] [review]
Patch v3

Should this go to Aurora to be consistent over all versions? If yes, I'm doing a special patch because a other related patch (Bug 734736) isn't for aurora.
Attachment #609452 - Flags: approval-comm-aurora?
Attachment #609452 - Flags: approval-comm-aurora? → approval-comm-aurora+
Patch adapted to comm-aurora
Comment on attachment 611567 [details] [diff] [review]
Patch for comm-aurora

[Triage Comment]
Switch flags to the patch that will land on aurora.
Attachment #611567 - Flags: approval-comm-aurora+
Attachment #609452 - Flags: approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.