Last Comment Bug 738991 - convert msgHdrViewOverlay.js to Services.jsm and MailServices.js
: convert msgHdrViewOverlay.js to Services.jsm and MailServices.js
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Message Reader UI (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 16.0
Assigned To: :aceman
:
Mentors:
Depends on: 654933
Blocks: 720356 720358
  Show dependency treegraph
 
Reported: 2012-03-24 15:15 PDT by :aceman
Modified: 2012-06-28 18:15 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (13.80 KB, patch)
2012-06-25 12:44 PDT, :aceman
squibblyflabbetydoo: review+
Details | Diff | Review

Description :aceman 2012-03-24 15:15:01 PDT

    
Comment 1 :aceman 2012-03-24 15:15:56 PDT
 var prefBranch = Components.classes["@mozilla.org/preferences-service;1"]
  Components.classes["@mozilla.org/abmanager;1"]
  Components.classes["@mozilla.org/abmanager;1"]
      var msgHeaderParser = Components.classes["@mozilla.org/messenger/headerparser;1"]
        var fileHandler = Components.classes["@mozilla.org/network/io-service;1"]
  var tagService = Components.classes["@mozilla.org/messenger/tagservice;1"]
  var msgHeaderParser = Components.classes["@mozilla.org/messenger/headerparser;1"]
  var books = Components.classes["@mozilla.org/abmanager;1"]
  let abManager = Components.classes["@mozilla.org/abmanager;1"]
    var viewMode = Components.classes["@mozilla.org/preferences-service;1"]
  let prefBranch = Components.classes["@mozilla.org/preferences-service;1"]
    let prefBranch = Components.classes["@mozilla.org/preferences-service;1"]
Comment 2 :aceman 2012-06-25 12:44:55 PDT
Created attachment 636446 [details] [diff] [review]
patch
Comment 3 Jim Porter (:squib) 2012-06-27 16:20:30 PDT
Comment on attachment 636446 [details] [diff] [review]
patch

Review of attachment 636446 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me, assuming you've run with this to make sure nothing obvious breaks. (It should be pretty safe, though.)
Comment 4 :aceman 2012-06-27 23:58:13 PDT
Yes, I've run with it, but no mozmill tests as they are flakey here.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-06-28 18:15:07 PDT
https://hg.mozilla.org/comm-central/rev/2d29995c7043

Note You need to log in before you can comment on or make changes to this bug.