Closed Bug 738998 Opened 12 years ago Closed 11 years ago

Some tooltips not working/ in style editor (is missing)

Categories

(DevTools :: Style Editor, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: aryx, Assigned: lie.r.min.g)

Details

(Whiteboard: [good first verify] )

Attachments

(1 file, 2 obsolete files)

Firefox trunk 2012-03-24

According to http://mxr.mozilla.org/mozilla-central/source/browser/devtools/styleeditor/styleeditor.xul#125 the 'eye' in the list of the style sheets should a have a tooltip, but it isn't shown when the mouse is moved over it.
Attachment #782536 - Flags: review?(fayearthur)
Thanks! One problem:

This causes movement when hovering over the filenames. The filenames jump up when you mouse over them. Not sure why, but we'll want to fix that.
Comment on attachment 782536 [details] [diff] [review]
Fix tooltip not showing in style editor

Cancelling review on this patch because the text jumping issue has to be fixed before we can land this.
Attachment #782536 - Flags: review?(fayearthur)
Attached patch 738998.patch (obsolete) — Splinter Review
Attachment #782536 - Attachment is obsolete: true
Attachment #819319 - Flags: review?(fayearthur)
Thanks for the patch.

There's no jumping now, but the "Save" label is always showing now on every style sheet. It should only show upon hovering the stylesheet, like before.
Attached patch 738998.patchSplinter Review
Attachment #819319 - Attachment is obsolete: true
Attachment #819319 - Flags: review?(fayearthur)
Attachment #825141 - Flags: review?(fayearthur)
Comment on attachment 825141 [details] [diff] [review]
738998.patch

Review of attachment 825141 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #825141 - Flags: review?(fayearthur) → review+
https://hg.mozilla.org/mozilla-central/rev/1fde6c44d6ad
Assignee: nobody → lie.r.min.g
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Whiteboard: [good first verify]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: