Closed
Bug 739001
Opened 13 years ago
Closed 12 years ago
Provide a single-argument nsIDirectoryService.get
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: darktrojan, Unassigned)
References
Details
Attachments
(1 file)
|
2.86 KB,
patch
|
benjamin
:
feedback-
|
Details | Diff | Splinter Review |
There's about a hundred uses of nsIDirectoryService.get in mozilla-central. Almost of all of them will be changed once bug 682360 is fixed, and the second argument will be redundant, so I'm filing this to make the cleanup simpler.
|
Reporter | |
Comment 1•13 years ago
|
||
I don't expect that this will land as-is, I'll probably move the code into the single-argument method and leave the QI'ing in the double-argument method.
|
|
Reporter | |
Updated•13 years ago
|
Attachment #609046 -
Flags: feedback?(benjamin)
|
|
Reporter | |
Comment 2•13 years ago
|
||
(In reply to Geoff Lankow (:darktrojan) from comment #0)
> There's about a hundred uses of nsIDirectoryService.get in mozilla-central.
Not to mention these:
http://mxr.mozilla.org/mozilla-central/search?string=NS_GetSpecialDirectory
|
||
Comment 3•13 years ago
|
||
This feels mostly like churn. The directory service is an abominable API to begin with; if we're going to start mucking with the API we should look at making it really right, not just putting lipstick on the pig.
|
|
||
Updated•13 years ago
|
Attachment #609046 -
Flags: feedback?(benjamin) → feedback-
|
|
Reporter | |
Updated•12 years ago
|
Assignee: geoff → nobody
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•